[jkloetzke]

No description provided.

[codecov]

Codecov Report

❌ Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.90%. Comparing base (7baba22) to head (fea9c40).

Files with missing lines	Patch %	Lines
pym/bob/scm/svn.py	94.44%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #714   +/-   ##
=======================================
  Coverage   89.89%   89.90%           
=======================================
  Files          50       50           
  Lines       16897    16931   +34     
=======================================
+ Hits        15189    15221   +32     
- Misses       1708     1710    +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jkloetzke]

@sbixl, could you check if this solves your problem?

[sbixl]

Sure, i will have a look on it next week. 👍

[sbixl]

I tested it and everything works perfectly. Thanks for implementing and providing this feature. 👍

There is just one minor cosmetic enhancement I would suggest: when the primary repository URL cannot be reached and the system switches to a fallback mirror, it would be helpful to log this explicitly. Right now, the command-line output gives the impression that the operation has failed, and then the checkout unexpectedly succeeds. An informational message about the fallback mirror would make the process much easier to understand.

my-release/hw-variant-b/project::fwup-target
CHECKOUT dev\src\project\fwup\1\workspace (initial checkout)
svn: E170013: Unable to connect to a repository at URL 'https://svn-server.com/svn/fwup/bin'
svn: E730061: Error running context: Es konnte keine Verbindung hergestellt werden, da der Zielcomputer die Verbindung verweigerte.
Warning: Checkout from 'https://svn-server.com/svn/fwup/bin' failed!
--> TODO: Print some info message that the fallback mirror is used now.
A fwup\changelog.txt
...

[jkloetzke]

Sure, makes sense. The warning now prints something like:

Warning: Checkout from 'file:///tmp/tmp9y4qfxba/does-not-exist/trunk' failed! Trying 'file:///tmp/tmp9y4qfxba/mirror/trunk' next...

I guess this is enough?

[sbixl]

Perfect, I just tested it again. Everything looks good to me!

[jkloetzke]

Thanks for testing!