Repository navigation
Make pwsh configurable on Windows - #719
Conversation
Allow projects to configure the PowerShell executable that is used on Windows. This enables the usage of PowerShell 7 (pwsh.exe) instead of the legacy Windows PowerShell. This is a project wide setting that is only taken from the root project. Defaults to "powershell" for backwards compatibility. Other platforms always use "pwsh".
Verify the config.yaml parsing including the project wide semantics, the propagation through the IR into the StepSpec and the interpreter selection of the PowerShell language.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #719 +/- ##
==========================================
- Coverage 89.89% 89.51% -0.38%
==========================================
Files 50 50
Lines 16897 16915 +18
==========================================
- Hits 15189 15142 -47
- Misses 1708 1773 +65 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The legacy powershell is horribly slow on Github actions.
Maybe it helps to speed things up...
6000504 to
d317961
Compare
|
In principle, I consider this feature highly valuable, as it would help reduce the dependency on PowerShell 5.x. I tested a migration to PowerShell 7 in our environment, but encountered compatibility issues that currently prevent a seamless transition. As a result, I am unable to provide any reliable performance benchmarks for comparison. Nevertheless, I would still recommend proceeding with the implementation of this feature. I'll investigate the compatibility issues further when I have an opportunity to do so. |
|
Thanks for the feedback. |
Historically Bob has used powershell.exe on Windows (Powershell 5) while all other platforms have used
pwsh(Powershell 7). Make it configurable on Windows.