[MarcKe]

string substitution was not available for replace in scmOverrides.
since it can break some old overrides, it is hidded behind a new policy flag.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.89%. Comparing base (7baba22) to head (b046116).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #720   +/-   ##
=======================================
  Coverage   89.89%   89.89%           
=======================================
  Files          50       50           
  Lines       16897    16901    +4     
=======================================
+ Hits        15189    15193    +4     
  Misses       1708     1708           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jkloetzke]

Could you give a use case where this is needed? So far I've never came across the need to replace things in overrides dynamically...

[jkloetzke]

This is exactly why I don't think this is something that should be enabled by default. Writing a regex pattern or replacement (with back references) is already hard enough in Yaml. Additionally substituting the pattern and replacement by Bob makes it very hard to use. How about making this a per-override setting (e.g. replaceSubst: True)?

[MarcKe]

Could you give a use case where this is needed? So far I've never came across the need to replace things in overrides dynamically...

Ok, I can understand why it might be weird for pattern, but replacement should definitely have this feature.

match:
    url: "https://awesometools.org/tools/*"
replace:
    url:
        pattern: "https://awesometools.org/"
        replacement: "${INTERNAL_MIRROR}/awesometools/"

for pattern, maybe the following is a bit of an artificial usecase:

match:
    url: "${GNU_MIRROR}/{tool_a, tool_b}/*"
replace:
    url:
        pattern: "${GNU_MIRROR}"
        replacement: "${INTERNAL_MIRROR}/some_awesome_tools/"
match:
    url: "${GNU_MIRROR}/*/*"
replace:
    url:
        pattern: "${GNU_MIRROR}"
        replacement: "${INTERNAL_MIRROR}/other_place_for_awesome_tools/"

Not sure if this is 100% valid.

I would agree to making string substitution for pattern configurable, but replacement should always have this.

[MarcKe]

Could you give a use case where this is needed? So far I've never came across the need to replace things in overrides dynamically...

Ok, I can understand why it might be weird for pattern, but replacement should definitely have this feature.

match:
    url: "https://awesometools.org/tools/*"
replace:
    url:
        pattern: "https://awesometools.org/"
        replacement: "${INTERNAL_MIRROR}/awesometools/"

for pattern, maybe the following is a bit of an artificial usecase:

match:
    url: "${GNU_MIRROR}/{tool_a, tool_b}/*"
replace:
    url:
        pattern: "${GNU_MIRROR}"
        replacement: "${INTERNAL_MIRROR}/some_awesome_tools/"
match:
    url: "${GNU_MIRROR}/*/*"
replace:
    url:
        pattern: "${GNU_MIRROR}"
        replacement: "${INTERNAL_MIRROR}/other_place_for_awesome_tools/"

Not sure if this is 100% valid.

I would agree to making string substitution for pattern configurable, but replacement should always have this.

Ok, I have used the per override setting for pattern and replacement in the end.

[jkloetzke]

Thanks for giving the rationale. LGTM.