Repository navigation
Raise the claude-agent-sdk floor past the resume injection advisory - #265
Merged
Merged
Conversation
claude-agent-sdk releases before 0.2.121 are affected by argument injection through the resume option (GHSA-h4mw-j7qp-8mwm, CRITICAL). The old floor of 0.1 let a fresh install resolve one, so raise it and record the change under Security in the changelog. The changelog entry shifts the line anchors of the persona-name allowlist by seven; re-anchor them with the expected text unchanged, as earlier changelog additions did. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The anchor shift added a three-line breadcrumb comment, which put the tests/unit package three lines over its shrink-only budget. Drop the comment; the anchors stay at 684/686/687/704 and the shift is recorded in the previous commit message. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
claude-agent-sdk>=0.1→>=0.2.121. Releases before 0.2.121 are affected by argument injection through theresumeoption (GHSA-h4mw-j7qp-8mwm, CRITICAL). Under the old floor, an install could still resolve a vulnerable SDK, for example where another constraint holds the SDK back.CHANGELOG.md: a### Securityentry under [Unreleased].tests/unit/test_no_persona_names_in_public_docs.py: the allowlist keys its historical breadcrumbs to CHANGELOG line numbers. The new 7-line entry moves them, so four anchors shift by +7 (677/679/680/697 → 684/686/687/704), and the expected text is byte-identical. The shift is recorded in the commit message instead of a comment:tests/unithas a frozen, shrink-only line budget, and a three-line comment pushed it over. CI's gate caught that, and the second commit removes the comment.No other floors are added: transitive packages stay unconstrained, as a library should leave them.
Verified (Python 3.14)
ruff checkandruff format --checkare clean.cf-file-budget checkpasses.Known CI reds that are not this PR
test (3.13): the timing-only ingest-scaling flake, already red on main (3.03x against an expected ~2x).claude-review: the review action itself errored (is_error:true) before reviewing anything.🤖 Generated with Claude Code