Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
hpmaxi
added this pull request to stack #158
September 23, 2026 20:20
hpmaxi
force-pushed
the
feat/78-authorization-model
branch
from
September 25, 2026 15:04
24c4174 to
5fa2ba1
Compare
hpmaxi
force-pushed
the
feat/78-authorization-model
branch
from
September 25, 2026 15:17
5fa2ba1 to
79a1b3e
Compare
hpmaxi
force-pushed
the
feat/78-authorization-model
branch
from
September 25, 2026 15:31
79a1b3e to
db102d8
Compare
luchobonatti
requested changes
Sep 25, 2026
luchobonatti
left a comment
Member
There was a problem hiding this comment.
Tests and clippy are green and the matrix is the right deliverable for #78. Two inconsistencies I would fix before merging, inline.
hpmaxi
force-pushed
the
feat/78-authorization-model
branch
from
September 25, 2026 17:50
db102d8 to
3078801
Compare
Fix the set_config and claim_wind_down rows, cite the refusal tests that exist, record that the share token keeps the default renounce_admin, and state what the deploy script actually checks.
4 tasks
luchobonatti
approved these changes
Sep 25, 2026
luchobonatti
left a comment
Member
There was a problem hiding this comment.
Matrix now matches the code row by row, and every cited test exists. Recording the share token renounce_admin gap here and fixing it in #169 is the right split. Workspace suite, clippy and fmt clean.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
_callerparameters acrossAsyncVault,ShareToken,NavOracle, andIdentityVerifierby explicitly callingcaller.require_auth().ShareToken:pause,unpause,mint,burn,forced_transfer,set_address_frozen,freeze_partial_tokens,unfreeze_partial_tokens,recover_balance,set_compliance,set_identity_verifier.IdentityVerifier:allowand allowlist verification enforcement.NavOracle:set_configandclear_latestrefusal for unauthorized callers.AsyncVault:cancel_wind_down_proposalrefusal for non-admin.managerrole distinction (AsyncVaultepoch closure vs.ShareTokenmint/burn/forced transfer) and script deployment safety.complianceandattesterare validated inAsyncVault::__constructor(separation of duties).fund,fulfill_epoch,activate_wind_down,finalize_wind_down_round,claim_wind_down) and their sound design rationale.docs/AUTHORIZATION_MATRIX.mdand link indocs/strata-product-and-architecture.md.Closes #78