Skip to content

refact(UniverSheet): compatible net11 - #1146

Merged
ArgoZhang merged 2 commits into
masterfrom
feat-univer
Sep 21, 2026
Merged

ArgoZhang merged 2 commits into
masterfrom
feat-univer

Conversation

@ArgoZhang

@ArgoZhang ArgoZhang commented Sep 21, 2026 •

Copy link
Copy Markdown
Member

Link issues

fixes #1145

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Enhancements:

  • Make UniverSheet asset URL resolution compatible with both .NET 9+ and earlier target frameworks.

@sourcery-ai

sourcery-ai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR refactors UniverSheet stylesheet URL properties with compile-time framework branching: .NET 9+ uses the asset resolver, while older targets—including .NET 11 compatibility scenarios as described—use static paths, preserving resource loading across target frameworks.

Flow diagram for framework-specific UniverSheet stylesheet resolution

flowchart TD
    A[UniverSheet renders] --> B{Target framework}
    B -->|NET9_0_OR_GREATER| C["Assets[UniverBundleStylePath]"]
    B -->|Older target| D[UniverBundleStylePath]
    C --> E[Load UniverSheet styles]
    D --> E
Loading

File-Level Changes

Change Details Files
Split UniverSheet asset URL resolution by target framework to support .NET 11 while preserving static paths on older targets.
  • Keep asset-manifest lookup for .NET 9 and later.
  • Provide static path-backed URL properties for pre-.NET 9 targets.
  • Move conditional compilation around both stylesheet URL properties for consistent framework-specific behavior.
src/components/BootstrapBlazor.UniverSheet/Components/UniverSheet.razor.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#1145 Make the UniverSheet component compatible with .NET 11 while preserving its asset URL behavior across supported target frameworks. ✅

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto Bot added the enhancement New feature or request label Sep 21, 2026
@bb-auto bb-auto Bot added this to the v10.0.0 milestone Sep 21, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@bb-auto bb-auto Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved by bb-auto

@ArgoZhang
ArgoZhang merged commit 915a587 into master Sep 21, 2026
3 checks passed
@ArgoZhang
ArgoZhang deleted the feat-univer branch September 21, 2026 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refact(UniverSheet): compatible net11

1 participant