Skip to content

[BI-2915] Update dataset fe to use observationUnitDbId #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jloux-brapi merged 1 commit into from
Aug 13, 2026
Merged

[BI-2915] Update dataset fe to use observationUnitDbId #481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/breeding-insight/service/StudyService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ export class StudyService {

let response: Result<Error, BiResponse>;
if (trial !== undefined && trial.externalReferences !== undefined) {
// TODO: Change to trialDbId when fixing bi-brapi study endpoint [BI-2962]
let externalReferenceId = BrAPIUtils.getBreedingInsightId(trial.externalReferences, '/trials');
// Throw if trial is missing ExternalReferenceId.
if (externalReferenceId === undefined) throw new Error("Trial is missing external reference.");
Expand Down
4 changes: 2 additions & 2 deletions src/views/import/Dataset.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,13 +510,13 @@ export default class Dataset extends ProgramsBase {

if(!this.isSubEntity){
datasetTableRow.expUnitId = this.removeUnique(unit.observationUnitName);
datasetTableRow.obsUnitId = BrAPIUtils.getBreedingInsightId(unit.externalReferences, "/observationunits");
datasetTableRow.obsUnitId = unit.observationUnitDbId;
} else {
let parentObsInfo = unit.observationUnitPosition.observationLevelRelationships.find((val) => val.levelOrder === 0);
if (parentObsInfo) datasetTableRow.obsUnitId = this.removeUnique(parentObsInfo.levelCode);
datasetTableRow.expUnitId = unit.additionalInfo.expUnitID;
datasetTableRow.subExpUnitId = this.removeUnique(unit.observationUnitName);
datasetTableRow.subObsUnitId = BrAPIUtils.getBreedingInsightId(unit.externalReferences, "/observationunits");
datasetTableRow.subObsUnitId = unit.observationUnitDbId;
}

// Env Year
Expand Down
Loading