Skip to content

SyncGenerator: support ImplicitArrayCreation #995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
omsmith merged 1 commit into from
Sep 14, 2026
+12 −0
Merged

SyncGenerator: support ImplicitArrayCreation #995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/D2L.CodeStyle.Analyzers/Async/Generator/AsyncToSyncMethodTransformer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,9 @@ private ExpressionSyntax Transform( ExpressionSyntax expr )
IdentifierNameSyntax identExpr => identExpr
.WithIdentifier( RemoveAsyncSuffix( identExpr.Identifier, optional: true ) ),

ImplicitArrayCreationExpressionSyntax implicitArrayCreationExpr => implicitArrayCreationExpr
.WithInitializer( Transform( implicitArrayCreationExpr.Initializer ) ),

ImplicitObjectCreationExpressionSyntax implicitObjectCreationExpr => implicitObjectCreationExpr
.WithArgumentList( Transform( implicitObjectCreationExpr.ArgumentList ) )
.WithInitializer( MaybeTransform( implicitObjectCreationExpr.Initializer, Transform ) ),
Expand Down
9 changes: 9 additions & 0 deletions tests/D2L.CodeStyle.Analyzers.Test/Async/Generator/AsyncToSyncMethodTransformerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,6 +633,15 @@ public void TaskToVoidReturnTypeNewObject() {
);
}

[Test]
public void ImplicitArrayCreationCreation() {
var actual = Transform( @"[GenerateSync] async Task<T> HelloAsync() { return new[] { await FooAsync(), Bar() }; }" );

Assert.IsTrue( actual.Success );
Assert.IsEmpty( actual.Diagnostics );
Assert.AreEqual( "[Blocking] T Hello() { return new[] { Foo(),Bar() }; }", actual.Value.ToFullString() );
}

[Test]
public void ImplicitObjectCreation() {
var actual = Transform( @"[GenerateSync] async Task<T> HelloAsync() { return new( await FooAsync() ); }" );
Expand Down
Loading