Updating vdiff goldens for PR 7518 - #7519
Merged
EdwinACL831 merged 1 commit intoSep 23, 2026
Merged
EdwinACL831 merged 1 commit into
EdwinACL831 merged 1 commit into
Conversation
github-actions
Bot
force-pushed
the
ghworkflow/vdiff-pr-7518
branch
5 times, most recently
from
September 23, 2026 16:23
2376921 to
9e8d337
Compare
github-actions
Bot
force-pushed
the
ghworkflow/vdiff-pr-7518
branch
from
September 23, 2026 17:36
9e8d337 to
7f5980a
Compare
EdwinACL831
marked this pull request as ready for review
September 23, 2026 17:37
EdwinACL831
merged commit Sep 23, 2026
feaf520
into
ecollazos/GAUD-10654_support_target_attribute
1 check passed
EdwinACL831
added a commit
that referenced
this pull request
Sep 23, 2026
* Adds support to target attribute with localized string for screen readers * Creates the inlineLinkIconStyles and imports it on d2l-link and d2l-empty-state-action-link. * Adds a new demo snippet * Refactors inlineLinkIconStyles to now be _generateInlineLinkIconStyles function. * Adds vdiff tests * Adds a new demo section showcasing the target attribute. * Implements the LinkMixin at the EmptyStateActionLink class * Reverts changes done at link.js * Reverts changes done at icon-styles.js * Removes unnecessary imports * Returns nothing of no text is provided * Reverts changes at link-mixin.js * Adds href check to maintain the original one. * Adds back the href property in the empty-state-action-link component since it is being used. * Updating vdiff goldens (#7519) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: Edwin Collazos <Edwin.Collazos@D2L.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the vdiff goldens for the changes in pull request #7518.
Please review the resulting report closely before merging to ensure the visual differences are expected.