Feat/sign in auth - #17
Merged
Merged
Conversation
- Fix environment variable name: NEXT_PUBLIC_WALLETCONNECT_PROJECT_ID (was NEXT_PUBLIC_WALLET_CONNECT_PROJECT_ID) - Add console logging to track SEP-53 and SEP-10 authentication flows - Log wallet type (WalletConnect vs Desktop) for better debugging - Log each step of the authentication process for mobile troubleshooting This enables WalletConnect to be properly initialized and allows better visibility into why Freighter mobile falls back to SEP-10 (as expected - WalletConnect doesn't support SEP-53 message signing for mobile). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Remove pause requirement from payment token and reserve price forms - Forms now always enabled (except when busy) - Automatically pause auctions when submitting config changes if needed - Add confirmation dialog showing both pause + config change actions - Support both direct execution (owner) and proposal draft (proposer) - Add helper text explaining auto-pause behavior - Improve UX by bundling dependent actions together This allows users to update auction settings directly without manual pause step. The system automatically includes a pause action before the configuration change when needed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
All admin forms across auction, governance, owner, and token admin pages now display compact previews when an action of the same type already exists in the proposal draft. This helps users understand what they're adding before submitting. New components and hooks: - useAdminDraftStatus: Hook to check if specific action types exist in draft and detect conflicts - AdminDraftActionPreview: Compact, collapsible preview card showing actions already in draft Updated form components to support draft previews: - AdminReservePriceForm (auction) - AdminPaymentTokenForm (auction) - AdminValueForm (governance) - AuthorityActionForm (owner/token authorities) - BatchMintGovernanceTokenForm (token) All admin pages now: - Import and use useAdminDraftStatus hook with relevant action types - Pass draft preview to forms when action exists in draft - Display small, non-intrusive preview cards above form inputs This gives users immediate visual feedback that an action is already queued in their proposal draft. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Replace plain text inputs for voting delay and voting period with DurationInput component that allows users to specify duration in days, hours, minutes, and seconds instead of raw seconds. Changes: - Import and use DurationInput from @/components/admin/duration-input - Update Drafts type to use number for votingDelay and votingPeriod - Simplify state management and validation logic (no more string parsing) - Add contextual helper text explaining each field's purpose - Update button disable logic to work with numeric values - Remove redundant "· Measured in seconds" text Benefits: - Users can now input "3 days, 2 hours" instead of calculating 259200 seconds - More intuitive and user-friendly admin experience - Consistent with DAO creation flow UX patterns 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Create PercentageInput component for BPS field conversions and update governance admin to use it for quorum settings. Users can now input quorum as a percentage (e.g., 10%) instead of basis points (1000). Changes: - New PercentageInput component with dual display showing both percentage and BPS - Update quorum field in governance admin to use PercentageInput - Change current value display from 'bps' format to percentage format - Simplify state management by using number types - Add contextual helper text Benefits: - More intuitive for users unfamiliar with basis points - Consistent with DAO creation flow UX patterns - Clear visual feedback of both percentage and technical BPS value 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
Add more descriptive helper text with practical examples to governance settings fields to better educate users about the impact of each parameter. Changes: - Voting delay: Added example that 1 day gives members time to see new proposals - Voting period: Added context about participation and common values (3-7 days) - Proposal threshold: Clarified purpose regarding spam prevention - Quorum: Added concrete example (10% means 10 out of 100 votes) All helper text now explains the field purpose, constraints, and practical implications. 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
Display clear before/after comparisons when users modify governance parameters. Impact messages appear in blue text below each field showing exactly what will change. Changes: - Voting delay: Shows formatted duration change (e.g., "1 day → 2 days") - Voting period: Shows formatted duration change with context - Proposal threshold: Shows vote count change (e.g., "10 → 20 votes") - Quorum: Shows percentage change (e.g., "10.00% → 15.00%") Impact messages only appear when a value differs from current settings, preventing visual clutter. 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
…dmin Improve visual hierarchy and consistency by adding Stack wrappers with gap="1" to group related elements together. This creates better visual separation between: - Current value display - Input field and helper text - Change impact message - Action button Changes: - Wrap current value in Stack gap="1" for consistent spacing - Wrap helper text and change message in Stack gap="1" to group them - Maintains overall card spacing of gap="3" between major sections - Consistent spacing pattern across all four governance settings fields Benefits: - Better visual grouping of related information - Consistent spacing reduces cognitive load - Aligns with design system spacing patterns - Improves form scanning and comprehension 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
Add explanatory comments clarifying why draft previews appear only in admin pages and not in proposal creation flows. Design rationale: - Admin pages: Users modify ONE setting at a time in isolation. Draft previews prevent accidental duplicate submissions by alerting users when a change is already queued (which they wouldn't see otherwise). - Proposal creation: Users see the FULL action queue below the form at all times, giving them complete visibility. Draft previews would be redundant and create visual clutter. This is an intentional architectural pattern, not a missing feature. Comments added to: 1. action-form-wrapper.tsx - explains why previews aren't passed to proposal forms 2. governance admin page - explains why previews are shown for admin forms Future maintainers can now understand this is by design. 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
- Update admin auction page to distinguish between three states: * 'not-launched': Show "Launch auctions" button with context-aware auth * 'paused': Show "Resume auctions" button (existing behavior) * 'active': Show "Pause auctions" button (existing behavior) - Context-aware messaging: * "Auctions have not yet been launched" for not-launched state * Different mint authority warnings for launch vs resume flows - Authorization flow supports both: * Owner can launch/pause/resume directly * Treasury owner can create governance proposal for these actions - Update dao-shell nav comments to clarify that tab shows if auctions_enabled is not false (true or null), ensuring tab shows even if auctions were re-enabled after initial disable 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
- Add detailed comments to API route explaining how status is determined: * No auction token + history = 'paused' * No auction token + no history = 'not-launched' - Update unpause handler label to be generic since it handles both 'launch' (first time) and 'resume' (after pause) scenarios. Admin page provides context-aware labeling based on actual status. - Clarify nav item logic in dao-shell: shows Auctions tab if auction_enabled is not false, ensuring tab appears even if auctions were re-enabled after being initially disabled. 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
Update transaction status messages in auction admin page to properly distinguish between launching auctions for the first time vs resuming after pause: - Submitted message: 'Auction launch submitted' vs 'Auction resume submitted' - Success message: 'Auctions launched' vs 'Auctions resumed' This ensures users get clear feedback about what action was performed, especially important for first-time auction launch which has different requirements (mint authority, creates first token, etc). 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (16)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit