feat(module): TridentBoost - #9066
Open
UIRAN23 wants to merge 1 commit into
Open
Conversation
Scales the riptide dash of a trident and optionally drops its water requirement. Vanilla gates riptide behind Player#isInWaterOrRain in both TridentItem#use and TridentItem#releaseUsing, and applies the dash through a single Player#push call whose strength comes from the enchantment. The module hooks exactly those spots and scales the impulse horizontally and vertically on its own, matching the setting layout of VehicleBoost.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scales the riptide dash of a trident and optionally lets it start on dry land.
TridentItemgates riptide behindPlayer#isInWaterOrRainin bothuseandreleaseUsing, and applies the dash through a singlePlayer#pushcall, with the strength coming from the enchantment (1.5 base, +0.75 per level above first). Those are the only spots involved, so the module needs one@ModifyExpressionValuecovering the water check in both methods and one@ModifyArgson the impulse.Settings:
HorizontalMultiplierandVerticalMultiplier— scale the dash separately, same layout asVehicleBoostin the same categoryOnLand— drops the water and rain requirementWorth knowing before reviewing:
pushruns client-side. Tested on 26.2 in singleplayer and on a remote server; up to roughly 2.5 the movement is accepted, above that it gets corrected. Default is 2.0.OnLandonly takes full effect in singleplayer, where the integrated server runs the same patchedTridentItem. On a remote server the dash still moves the player, but the server never starts the spin attack, so there is no spin damage and the movement looks ordinary to anticheats.Meteor has a module in the same spirit. Vanilla offers no other injection points, so those coincide, but this module is written for LiquidBounce and shares neither its structure nor its settings.