Skip to content

add(ship): new models and transformation rules - #571

Merged
zzacharo merged 1 commit into
CERNDocumentServer:masterfrom
zubeydecivelek:ship
Sep 14, 2026
Merged

zzacharo merged 1 commit into
CERNDocumentServer:masterfrom
zubeydecivelek:ship

Conversation

@zubeydecivelek

Copy link
Copy Markdown
Contributor

@zubeydecivelek
zubeydecivelek marked this pull request as draft August 6, 2026 12:06
@zubeydecivelek zubeydecivelek linked an issue Aug 7, 2026 that may be closed by this pull request
@zubeydecivelek
zubeydecivelek marked this pull request as ready for review August 25, 2026 12:50
@zubeydecivelek
zubeydecivelek force-pushed the ship branch 6 times, most recently from 46ac610 to 05d168f Compare September 11, 2026 14:13
"((980__.a:NOTE OR 980__.a:Note OR 980__.a:ConferencePaper) AND 690C_.a:SHiP) OR "
"980__.a:SHiPPUBDRAFTFINAL OR 980__.a:SHiP_Papers OR "
"(980__.a:INTNOTE AND 693__.e:SHiP) "
"-980__:DELETED -980__.c:MIGRATED -980__.a:DUMMY"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the MIGRATED from the query so we can catch cross communities records :)

)

__ignore_keys__ = {
"100__v", # complete affiliation

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are all the ignored confirmed with SIS? can we upgrade any to globally ignored?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the PR, thanks!

"7277793b-5fce-458a-a3c4-e05a6cc43c69": {
# ship
"label": "EP approval", # shown in UI buttons/headings
"referee_group": "cds-ph-ep-publication", # CERN e-group slug

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this correct? shouldnt be cds-ph-ep-publications-referee ? is it used for adding the referee group?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked from legacy code, it's SPS see it should be cds-ph-ep-publications-referee-non-lhc by default i'll change, thanks

@zubeydecivelek
zubeydecivelek force-pushed the ship branch 2 times, most recently from d86f4f6 to 4f53947 Compare September 14, 2026 11:48
@zzacharo
zzacharo merged commit a1bf2f0 into CERNDocumentServer:master Sep 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

migration: SHiP

2 participants