isolde: 340, 852, 035 handling - #612
Merged
Merged
Conversation
kpsherva
reviewed
Sep 23, 2026
| "999C6v", | ||
| # ResearchModel.__ignore_keys__ covers the shared publication baseline | ||
| # Only ISOLDE-specific additions are listed here. | ||
| __ignore_keys__ = ResearchModel.__ignore_keys__ | { |
Contributor
There was a problem hiding this comment.
unfortunately this change is failing the tests :(
kpsherva
reviewed
Sep 23, 2026
| raise UnexpectedValue(field=key, subfield="a", value=value, stage="transform") | ||
|
|
||
|
|
||
| @model.over("additional_descriptions", "^852__") |
Contributor
There was a problem hiding this comment.
isn't it easier to add these fields to ignored? also, by raising IgnoreKey at the end you might also silently ignore other subfields of this field
Contributor
Author
There was a problem hiding this comment.
hmm but I want to ignore specific values of the 852 subfields only. Keeping in mind also that this could go to the research/base class. Isn't it better like that?
Contributor
There was a problem hiding this comment.
in the ignore keys you can only add the specific ones, you can't add the whole field
but I am re-reading this and now I understood why you do this, sorry 😅 LGTM
zzacharo
force-pushed
the
add-isolde-rules
branch
from
September 24, 2026 13:50
3ec812c to
9f8c1fe
Compare
kpsherva
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #478