Skip to content

fix(harvester): skip harvest when metadata did not change #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kpsherva merged 1 commit into from
Sep 16, 2026
Merged

fix(harvester): skip harvest when metadata did not change #968

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions site/cds_rdm/inspire_harvester/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@ def retrieve_identifiers(identifiers, scheme):
yield ident["identifier"]


def _keys_without_empty_values(value):
"""Keys whose values are not None, [] or {} (empty dump placeholders)."""
return {k for k, v in value.items() if v not in (None, [], {})}


def compare_metadata(a, b):
"""Compare metadata based on id key only."""
# If both are dicts
Expand All @@ -30,11 +35,13 @@ def compare_metadata(a, b):
if "id" in a and "id" in b:
return a["id"] == b["id"]

keys_a, keys_b = _keys_without_empty_values(a), _keys_without_empty_values(b)

# Otherwise compare keys recursively
if a.keys() != b.keys():
if keys_a != keys_b:
return False

return all(compare_metadata(a[k], b[k]) for k in a)
return all(compare_metadata(a[k], b[k]) for k in keys_a)

# If both are lists
if isinstance(a, list) and isinstance(b, list):
Expand Down
Loading