You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
zero-rk hip-chipStar hardcodes build host rocThrust and rocPRIM include paths #2006
zero-rk (https://github.com/CHIP-SPV/zero-rk, branch hip-chipStar at a0783ad1) hardcodes build host include paths for the zerork_cuda target in src/zerork/CMakeLists.txt lines 55 and 57:
mechanism_cuda.cpp includes <thrust/device_vector.h>, so the build uses whatever rocThrust and rocPRIM sit at those paths. On a machine that has them, they are an old rocPRIM that uses warpSize as a compile time constant, and the build fails against chipStar main since warpSize became a run time value (#1934):
rocprim/intrinsics/thread.hpp:42:24: error: constexpr function never produces a constant expression [-Winvalid-constexpr]
rocprim/device/detail/lookback_scan_state.hpp:127:32: error: constexpr variable 'padding' must be initialized by a constant expression
On any other machine the paths do not exist and the build silently depends on whatever thrust is otherwise on the include path. No rocThrust or rocPRIM dependency is declared anywhere in zero-rk.
Reproduce: clone zero-rk hip-chipStar, build as in scripts/build_aurora.sh (-DENABLE_GPU=ON -DENABLE_MAGMA=OFF, hipcc) against a chipStar main install on a host where /space/pvelesko/install/HIP/rocPRIM/2025.04.22 exists.
Fix in zero-rk: replace the two paths with find_package(rocthrust CONFIG REQUIRED) and link roc::rocthrust, which carries the rocThrust include path and its rocPRIM dependency. The libraries and apps lane in #1945 builds zeroRK and needs it to pick up the rocThrust and rocPRIM that lane builds. zero-rk has issues disabled, so this is the tracking record. No upstream report exists; the hardcoded paths are specific to the CHIP-SPV fork.
Activity
ci: libs-apps corrects the comment on the zeroRK include path
ci: libs-apps builds zeroRK without the -I workaround for rocPRIM and…
ci: libs-apps corrects the comment on the zeroRK include path
ci: libs-apps builds zeroRK without the -I workaround for rocPRIM and…