Repository navigation
Conversation
The stamp hashed the path of every non-source file and the full contents of every CMakeLists.txt and .cmake file. Runners that alternate between PRs therefore saw a different stamp on almost every run and wiped the build tree each time (k3 runs started ninja at [1/1008], about 40 min per lane). Ninja depfiles already track source and header contents, and CMake re-runs itself when a CMakeLists changes. The rebuilt-LLVM case is covered by the LLVM install listing (PR #2074 deps). So the stamp now keeps only what ninja cannot see: the LLVM install, the list of header paths (a new header can shadow an already included one), and the option()/CACHE lines of the CMake files (CMake keeps cached values across a re-run). The workflow file itself stays in the stamp. Fixes #2193.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The self-hosted unit-test lanes wiped their persistent build tree whenever the stamp changed, and the stamp hashed every non-source file path plus full CMakeLists/.cmake contents, so runners alternating between PRs rebuilt from scratch almost every run. Ninja and CMake already track content edits, so the stamp now covers only what they cannot see: the LLVM install, the workflow file, the list of header paths (a new header can shadow an included one) and the option()/CACHE lines of the CMake files (CMake keeps cached values).
The first run on each runner after this lands still wipes once, since the stamp format changed. ccache on k3 being full is a separate problem.
Fixes #2193
This PR was generated using AI