Implement motion base class functions in pi controller - #2
Merged
Merged
Conversation
Kupaianaha
reviewed
Nov 20, 2025
prkrtg
reviewed
Nov 24, 2025
scizen9
reviewed
Nov 24, 2025
scizen9
reviewed
Nov 24, 2025
Kupaianaha
reviewed
Dec 1, 2025
Kupaianaha
reviewed
Dec 1, 2025
Kupaianaha
left a comment
Kupaianaha
left a comment
There was a problem hiding this comment.
Should be good after the is_closed_loop change -> is_loop_closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We could think about having status codes in the hardware base class?