Repository navigation
Studio: new preset defaults in the UI language (#772) - #773
Merged
Merged
Conversation
The new shader/background name, the default slider label, variation names and the starter shader comment header become the user's own editable text, so they are translated at creation like the #759 import fix. Adds EN entries for the header lines and a test. Test count 3186. Co-authored-by: caganturgut <271973834+caganturgut@users.noreply.github.com>
|
CaYaDraft — pull request Summary Files
Note Stopping here. I will not merge, push, or change this pull request until you ask.
|
… user content (#772) startDraft marked every new draft dirty, so discarding an unedited one asked for confirmation in both languages (pre-existing on main). The Save button stays highlighted for unsaved drafts via !selectedId. The self-test untranslated scan now skips elements marked data-user-text (text subtree) or data-user-attr (title/placeholder); Studio marks user preset names with them. Test count 3189. Co-authored-by: caganturgut <271973834+caganturgut@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #772.
In the English UI, Studio -> + Shader created a visualizer named
Yeni Görselleştiriciand the discard prompt showed it. Like #759, the defaults that become the user's editable text are now written in the UI language at creation:Amountslider labelTests:
tests/studio-new-preset-i18n.test.js;npm test3186/3186. CHANGELOG (Unreleased -> Studio) and test counts updated.