Repository navigation
[pull] master from tensorflow:master - #8844
Merged
Merged
Conversation
The size inflation check in WhileLoopInvariantCodeMotion ran before the invariance test. Every get-tuple-element of an N element loop state therefore walked the whole tuple shape: Theta(N^2) per loop per run. Test invariance first, so those get-tuple-elements are rejected before any shape is walked. Both filters are pure, so the hoisted set, its order and the resulting HLO are unchanged. Also skip the post order for the domain bail out scan and build the while instruction's debug string only when VLOG reads it. Adds tests for the ratio decision, tuple operand leaf counting and the linear shape size call count. PiperOrigin-RevId: 984946237
PiperOrigin-RevId: 984990786
…bility. PiperOrigin-RevId: 985023382
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )