Repository navigation
QA: Fix the display of mac addressed - #398
Merged
Merged
Conversation
TheWitness
commented
Oct 19, 2026
TheWitness
commented
Member
- Update the CHANGELOG to be more readable as well.
* Update the CHANGELOG to be more readable as well.
xmacan
previously approved these changes
Oct 19, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Searching for a displayed, formatted vendor prefix does not match its unseparated database value.
1 open issue
What changed in this PR
Corrects vendor MAC prefix formatting in Device Tracking and simplifies the changelog.
Changes:
- Applies MAC formatting to vendor prefixes instead of postal addresses in listings and exports.
- Enables formatting for six-character prefixes.
- Reorganizes and shortens development changelog entries.
| File | Description |
|---|---|
mactrack_vendormacs.php |
Corrects formatting targets in listings and exports. |
lib/mactrack_functions.php |
Allows six-character MAC prefixes to be formatted. |
CHANGELOG.md |
Simplifies entries and records the display fix. |
Review effort: Balanced
|
xmacan
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.