[TheWitness]

Description

mikrotik_graphs_url_by_template_hashs() in setup.php declared its first
parameter with a strict array type hint:

function mikrotik_graphs_url_by_template_hashs(array $hashes, int $host_id = 0, string $search = ''): string

The Wireless APs view (mikrotik_wireless_aps()) calls it with the
$wireless_station_hashes global, and the Wireless Registrations view
(mikrotik_wireless_regs()) calls it with the $wreg_hashes global. Neither
global is ever populated in mikrotik_config_arrays(), so both are null.
Under strict typing, passing null throws an uncaught TypeError, which Cacti
traps in its shutdown handler and then disables the plugin:

Uncaught TypeError: mikrotik_graphs_url_by_template_hashs(): Argument #1 ($hashes)
must be of type array, null given, called in .../mikrotik/mikrotik.php on line 1464
and defined in .../mikrotik/setup.php:1121

This change makes the $hashes parameter nullable (?array). The function
already renders a graceful "Graphs Skipped by Rule, or Not Created" placeholder
whenever the hash list is empty (cacti_sizeof(null) returns 0), so an
unpopulated hash global now produces that placeholder instead of a fatal error.

Related Issue

Fixes the runtime TypeError reported from mikrotik.php line 1464 that causes
Cacti to disable the mikrotik plugin.

Motivation and Context

A fatal TypeError reaching Cacti's shutdown handler causes the entire plugin
to be auto-disabled, taking down all MikroTik collection and views. Guarding the
single boundary function that receives these (currently unpopulated) hash list
globals resolves the crash for both the Wireless APs and Wireless Registrations
views without changing any existing, working behavior.

How Has This Been Tested?

• php -l setup.php — no syntax errors.
• Confirmed all six call sites of mikrotik_graphs_url_by_template_hashs()
  (interfaces/queues/trees/wireless APs/users/wireless regs); the four with
  populated hash globals are unaffected, and the two with null globals now
  render the placeholder link instead of throwing.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation repository accordingly.

[Copilot]

🟡 Changes recommended

The fallback masks incorrect registration-hash wiring, lacks a null regression test, and needs a changelog entry.

3 open findings

• Fix mismatched wireless registration hash variable · New
• Document nullable hash-list TypeError fix in changelog · New
• Add regression test for null hash-list input · New

What changed in this PR

Prevents null hash globals from triggering a plugin-disabling TypeError.

Changes:

• Allows nullable graph-template hash lists.
• Documents placeholder behavior for null lists.

File	Description
setup.php	Adds nullable hash-list handling and PHPDoc.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.