Repository navigation
build: adopt libopenapi v0.41.8 with YAML index fix - #1040
Conversation
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
libopenapi correction and importer verification go.mod, internal/openapiimport/testdata/yaml_merge_race/README.md, internal/openapiimport/tla/yaml_index_owner/README.md |
The root dependency uses a newer CaliLuke libopenapi pseudo-version. The documentation records upstream v0.41.8 behavior, TLC results, and importer validation results. |
Vacuum contract gate pins and instructions http/codegen/openapi/v3/contract_vacuum_test.go, .agents/skills/loom-framework/references/openapi-validation.md, http/codegen/openapi/internal/ir/lean/discriminator_metadata/README.md, internal/openapiimport/testdata/yaml_merge_race/README.md |
The contract test and gate documentation use Vacuum v0.35.4 and released libopenapi v0.41.8. The instructions describe the direct requirement and when to remove the pin. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix
Merge Risk: 
735fb
-
No verified merge-blocking risk remains in the dependency and contract-gate updates.
Pre-merge checks: 
-
Check name Status Explanation Resolution Docstring Coverage Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi… Write docstrings for the functions missing them to satisfy the coverage threshold. -
Check name Status Explanation Title check The title clearly and concisely identifies the main dependency update and YAML index fix described in the changeset. Description check The description directly explains the libopenapi and Vacuum updates, the YAML index correction, and the reported validation results. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files. (5 skipped: 5 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit checks the version trail,
With ears held high above the detail.
New pins are noted, tests are run,
The merge paths pass beneath the sun.
Then off I hop, my review done!
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Adopt libopenapi v0.41.8 plus the pending effective YAML component-index correction in upstream PR #673, using the published
CaliLuke/libopenapicommit2be7e43876e4. Released v0.41.8 alone still fails the existing alias/merge reference regressions.Update the isolated contract validator to Vacuum v0.35.4 with released libopenapi v0.41.8, replacing its enum-fix fork override. Dependency notes retain the exact return-to-upstream condition and validation evidence.
Validation: lint and the full root test suite (both passed in the push gate); focused importer normal/rejected cases and YAML races; OpenAPI v3 suite; contract lint and downstream client-generation smoke; generated compilation and independent-process determinism. All 34 captured ordinary/nullable design and generated artifacts are byte-identical to the previous pin.