Repository navigation
Fix optional collection and nullable enum validation - #1045
Merged
Merged
Conversation
Skip optional native collection predicates when nil represents absence. Preserve protobuf nil-as-empty validation through the shared representation context. Add direct and generated regressions, bounded presence modeling, and regeneration guidance. Fixes #1042
|
Caution Review failedThe pull request is closed. Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix two validation inconsistencies in separate atomic commits:
Consumers should regenerate affected code and specifications.
Validation:
make lintandmake testpassed through the push hook, plus direct regression tests, generated HTTP/JSON-RPC/gRPC compilation and behavior checks, bounded before/after output comparisons, process-isolated byte determinism, OpenAPI parser/Vacuum checks, and independent reviews. Opt-in TLA+ models reproduce the defects and check the corrected contracts.Fixes #1042
Fixes #1037