Skip to content

Fix CI retry-policy tests that race attempt deadlines - #1054

Merged
CaliLuke merged 1 commit into
mainfrom
luca/fix-ci-activity-policy
Oct 28, 2026
Merged

CaliLuke merged 1 commit into
mainfrom
luca/fix-ci-activity-policy

Conversation

@CaliLuke

Copy link
Copy Markdown
Owner

The Selvedge error-policy tests asserted exact invocation counts while also imposing a one-second attempt deadline. If scheduling delayed the handler past that deadline, native timeout policy correctly admitted another attempt—even though the eventual handler error was non-retryable.

Remove the unrelated deadlines from retry-policy and retry-option tests, retain their exact invocation counts, and require the expected permanent error. Separate timeout tests now verify native defaults and portable overrides using cancellation, typed timeout errors, and recorded options. The overall test context still bounds execution.

Validation: a controlled delayed-handler probe reproduced two invocations with the old deadline and one without it; an opt-in TLA model records the counterexample and corrected assumption. The complete Selvedge package passed 30 race-enabled runs with the failing CI shuffle seed, followed by a final affected-package race run after a mechanical allocation correction. No production runtime or dependency behavior changed, and no retry/skip was added to the tests.

Closes #1053.

@CaliLuke
CaliLuke merged commit e974017 into main Oct 28, 2026
1 of 15 checks passed
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@CaliLuke
CaliLuke deleted the luca/fix-ci-activity-policy branch October 28, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate intermittent permanent-error activity count in race CI

1 participant