Repository navigation
Fix CI retry-policy tests that race attempt deadlines - #1054
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Selvedge error-policy tests asserted exact invocation counts while also imposing a one-second attempt deadline. If scheduling delayed the handler past that deadline, native timeout policy correctly admitted another attempt—even though the eventual handler error was non-retryable.
Remove the unrelated deadlines from retry-policy and retry-option tests, retain their exact invocation counts, and require the expected permanent error. Separate timeout tests now verify native defaults and portable overrides using cancellation, typed timeout errors, and recorded options. The overall test context still bounds execution.
Validation: a controlled delayed-handler probe reproduced two invocations with the old deadline and one without it; an opt-in TLA model records the counterexample and corrected assumption. The complete Selvedge package passed 30 race-enabled runs with the failing CI shuffle seed, followed by a final affected-package race run after a mechanical allocation correction. No production runtime or dependency behavior changed, and no retry/skip was added to the tests.
Closes #1053.