Give the atccryo collection a timeout its hardware reads can meet - #239
Merged
Merged
Conversation
mikelangmayr
commented
Oct 2, 2026
Contributor
- atccryo answers keys.read by querying the cryocooler once per keyword, measured at ~2.9s for its 19 keywords over TCP
- bamboo allows only timeout_s/2 for the reply, so the 2.0s default gave it a 1.0s window and every tick failed with "every read failed"
- Set timeout_s: 10.0 on that collection only; raising the default would break the motion collections, whose 5s interval cannot satisfy interval_s > 1.5 x timeout_s
prkrtg
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.