Repository navigation
Require proxyLogin and proxyPassword for FunCaptchaRequest - #42
Closed
capmonster-sdk-bot[bot] wants to merge 1 commit into
Closed
capmonster-sdk-bot[bot] wants to merge 1 commit into
capmonster-sdk-bot[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The FunCaptchaTask article lists all five custom proxy parameters as required: https://docs.capmonster.cloud/docs/captchas/funcaptcha-task.txt (quote:
**proxyType** (string, required):; proxyAddress, proxyPort, proxyLogin, proxyPassword are likewise required).TenDI
aidEncrypted(**aidEncrypted (inside metadata)** (string, optional):, https://docs.capmonster.cloud/docs/captchas/tendi.txt) is already supported inTenDIMetadata; no change needed.Changes
src/Requests/FunCaptchaRequest/FunCaptchaRequest.ts:proxytype now requiresproxyLoginandproxyPassword; JSDoc updated. Breaking for callers that omitted them.src/Requests/RequestsSerialization.u.spec.ts: FunCaptcha minimal case now passes login/password.package.json: version 3.0.0.Testing
npx tsc --noEmit && npm run test-unitOpen questions
None.
Prepared automatically by the SDK update bot. Please review before merging.