Repository navigation
Add optional seed to get_train_val_test_loader - #254
Open
filipetessaro wants to merge 1 commit into
Open
filipetessaro wants to merge 1 commit into
filipetessaro wants to merge 1 commit into
Conversation
Up to standards ✅🟢 Issues
|
| Category | Results |
|---|---|
| Security | 2 high |
🟢 Metrics 0 complexity
Metric Results Complexity 0
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this adds an optional
seedargument to the threeget_train_val_test_loaderfunctions inchgnet/data/dataset.py(GraphData,StructureJsonDataand the module-level one), as suggested in #253.With
seed=None, the default, nothing changes: the split still uses the globalrandomstate, so code that callsrandom.seed()first gets the same split as before. With an integer, the split comes fromrandom.Random(seed), so a retrain can rebuild the same train/val/test mp-ids without touching global state. Only the split is seeded; DataLoader shuffling inside each set is unchanged.Added
test_data_loader_seedintests/test_dataset.py(same seed gives the same split, different seeds don't).This doesn't recover the 0.2.0/0.3.0 test ids from the issue, of course. That part still needs the original lists if you have them.
Report: https://github.com/paper-rerun/paper-rerun/blob/main/reports/2023-deng-chgnet/REPORT.md
This change was prepared with AI agents and reviewed by a human before opening. How we work: https://github.com/paper-rerun/paper-rerun/blob/main/METHOD.md