Adding in cleaned up SGPstateData and test regarding projections and … - #1524
Merged
Merged
Conversation
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_df6cce5e-1a1a-4ea5-9301-19ff18a05e64) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…years forward
Note
Low Risk
Expected impact is demo/state metadata and regression tests rather than core analysis logic, though bad projection metadata could still affect projection and target outputs in production states.
Overview
No hunks were included in the supplied diff, so this summary follows the PR title and description.
The PR is intended to land cleaned-up
SGPstateDatametadata (likely projection-related settings such as years-forward / max forward progression) and to add or tightentestSGPcoverage for student growth projections under those configurations (e.g. EOCT-styleDEMO_EOCTruns that setmax.sgp.target.years.forwardand related target options).Reviewers should confirm the actual
SGPstateDatabundle changes and any new or updated assertions intestSGPonce the full diff is available.Reviewed by Cursor Bugbot for commit 34dd2e9. Configure here.