Take graphcore 85be3db, which bounds the no-tool-call scolding loop - #227
Open
shellygr wants to merge 1 commit into
Open
Take graphcore 85be3db, which bounds the no-tool-call scolding loop#227shellygr wants to merge 1 commit into
shellygr wants to merge 1 commit into
Conversation
Submodule and pyproject pin only. Nothing else landed on graphcore master between the pin we were on and this one, so the range is graphcore#38 alone. The scolding node tells a model that ends its turn without a tool call to call one, then routes back for another try. Nothing counted how often that happened, so a model that answered every scolding the same way cycled until langgraph's recursion limit. In one run an agent went round 494 times, and the GraphRecursionError it finally raised propagated out of the structural-invariant phase and killed a run whose property extraction had already finished. graphcore now raises NoToolCallsError after three consecutive no-tool turns. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is
The graphcore submodule and the
pyproject.tomlpin move from2177f57to85be3db. Thatrange is Certora/graphcore#38 and nothing else.
uv.lockstays as it is, because[tool.uv.sources]resolves graphcore to the local path, so the SHA lives in those two placesonly. It is the same file set the previous bump touched.
What #38 changes
An AI turn with no tool call cannot advance a graphcore graph, so
_scolding_nodeappends amessage saying every turn must end with a tool call and routes back for another try. Nothing
counted the retries. A model that answers every scolding the same way cycles until langgraph's
recursion limit, hundreds of paid calls later.
That happened on a cloud run here. One agent returned an empty message after writing a rough
draft and went round 494 times over about fifteen minutes, taking most of the run's LLM spend,
almost all of it cache-write on re-sending the growing scolded conversation. Three other agents
in the same run reached the scolding node once each and recovered on the next turn, which is
where the new limit of three comes from.
What it does not fix
The reason that run died rather than losing a single phase is separate. The
structural-invariant task is gathered without
return_exceptions=True, so its failure cancelsAutoSetup and takes the process down. #214 removes that phase and the fatal path with it. This
bump only stops the agent from spinning in the first place.
Checks
scripts/check_submodule_pin.py, pyright and pytest all run clean locally.