Export the GlobalExcludeArg normalizer - #37
Merged
Conversation
`_make_exclude_pred` is the one place the regex form and the callable form of a `GlobalExcludeArg` are read. A caller that holds one and wants to ask the question itself, instead of handing the argument to a tool suite, had to write that branch again. Make it public. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
jtoman
approved these changes
Sep 4, 2026
jtoman
left a comment
jtoman
left a comment
Contributor
There was a problem hiding this comment.
I've wanted this myself for other things I've been playing with; thanks for getting to it :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make_exclude_pred(was_make_exclude_pred) turns either surface form of aGlobalExcludeArg, the fullmatch regex or the callable, into a single exclude predicate. It was private, so anyone holding aGlobalExcludeArgwho wanted to answer "is this path excluded?" without going throughfs_toolshad to repeat the regex-vs-callable branch.Behaviour and signature are unchanged. The two callers in the file are updated, and the docstring now says why it is exported.
The caller that needs it checks agent-authored source paths against the same readability rule the agent's own file tools serve them through.
🤖 Generated with Claude Code