Fix SearchIndex directory leak - #51
Merged
Merged
Conversation
… order initLookupOutputStream() and openSearcher() opened FSDirectory instances into local variables that were never retained on the object, so closing the IndexWriter / DirectoryTaxonomyReader built on top of them never closed the Directory itself — closing a Lucene IndexWriter/Reader does not close the Directory it was opened on. close() also closed the writers before the searcher/reader built on top of them, with no try/finally, so a failure partway through skipped the remaining shutdown steps. Net effect: native file handles could stay open after SearchIndex.close() returned, occasionally surfacing downstream as background writes into the index directory after teardown assumed it was done (e.g. a DirectoryNotEmptyException from a temp-dir cleanup right after close()). Retain the Directory instances as fields and close everything via IOUtils.close(), which closes the searcher/reader before the writers and guarantees every Closeable is closed even if an earlier one throws. Added a regression test asserting the retained Directory fields are actually closed after SearchIndex.close(). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
cojosh
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.