Conversation
Releases through 1.5.0 were written by hand, always with the same two parts: the CHANGELOG section for the version, then the pull requests GitHub generates. This reproduces that shape from the tag, so the release stops depending on someone remembering to draft it. A version with no matching CHANGELOG section still gets a release, with the generated half only and a warning in the log.
Thirteen of the fourteen code smells reported on new code: - Component props marked read-only in SideMenu, IconRenderer, Page and PageWithAuth. - Dropped a fragment wrapping a single child in SystemsPopup. - Re-exported toast with export...from instead of importing it only to export it again. - Replaced an anchor with no href in Footer with a span. It was never navigable, and an anchor without href is skipped by keyboard navigation while still reading as a link to assistive technology. - Collapsed two conditionals that only restated their own operands. - Moved Dialog's text out of a children prop and between the tags in the UserPopup story. Also silenced rollup's module-level directive warnings, which MUI emits once per file: the build printed 381 warnings, 360 of them these, and real ones were unreadable among them. The build now reports 21.
v2 becomes the version new consumers get. With LATEST_MAJOR still at 1 here, the next 1.x fix would move latest back from 2.x to 1.x, so this has to reach main before any further v1 release. From now on 1.x publishes under v1-latest. Nothing is published by this change; it only takes effect on the next release tag.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings
developup tomainahead of the 2.0.0 release.Why this has to land before the v2 tag
43a2179setsLATEST_MAJORto2in v1'sdeploy.yml. The publish workflow runs from the tag onmain, so whilemainstill says1, the next 1.x release would move the npmlatestdist-tag back from v2 to v1. With this merged, 1.x publishes underv1-latestinstead.Also included
cc6aa39— the release job now creates the GitHub release from the CHANGELOG section plus GitHub's generated notes, so it no longer depends on someone drafting it by hand.fbb9ed0— the 13 code smells SonarCloud reported on new code, and rollup's module-level directive warnings silenced. The build printed 381 warnings, 360 of them MUI'use client'noise; it now prints 21, which is what let the real ones be read at all.Nothing here is published by merging. The v1 line stays at 1.5.0 on npm until someone tags a 1.x release; these changes ride along with whatever that turns out to be.