Repository navigation
fix: restore main build — missing CancellationException import in SearchViewModel - #319
Merged
Merged
Conversation
The guard rethrows CancellationException from the catch block, which never had the import, so :app:compileDebugKotlin failed on main after #318 merged. One import, no behaviour change.
likeTargetBody was an instance member on the Hilt-injected class, so the unit test could not call it (Unresolved reference in :app:compileDebugUnitTestKotlin). It is now a file-level internal fun next to the endpoints, which the test already reaches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores main's build after #318/#317 merged. Two compile breaks, one import and one visibility fix:
unSearch's stale-response guard without importing it — :app:compileDebugKotlin\ failed on main (\e: SearchViewModel.kt:208:22 Unresolved reference 'CancellationException').
CI green on \d6f1baa.