Fix unsound regex fast path, output path collisions, and drop-sink validation#47
Merged
Merged
Conversation
eitamring
force-pushed
the
fix/regex-assertions-and-path-collisions
branch
from
July 11, 2026 02:59
f6c88d7 to
fefe2af
Compare
This was referenced Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three fixes from a pre-release audit. No performance changes.
^PING$matched any line containing PING and could shadow later rules. The fast path now skips any pattern with a zero-width assertion. Regression tests plus a parity fuzz against plain regexp (1.3M execs).vet, test, and race pass; the 1M-line demo output is byte-identical to main.