Fix examples/slim.php and sse-interception.php, reframe as best-effort - #6
Merged
Merged
Conversation
…est-effort Both examples claimed to demonstrate a PHP fatal but triggered a catchable Error instead (a method call on null), which goes through the exception handler, not the shutdown handler the fatal-only mechanism (and, for the SSE example, setShutdownInterception()) actually targets. slim.php: split into /crash (a normal exception, answered by Slim's own error middleware) and /fatal (a genuine, portable, reproducible fatal — memory_limit lowered then exceeded — answered by this library instead). sse-interception.php: replaced the fake trigger with the same genuine fatal. Both verified in real execution. README/composer.json: reframed the tagline as 'best-effort, last-resort' rather than implying every fatal is caught — a SIGKILL, an OOM-killed process or a segfault give register_shutdown_function() no chance to run at all, and the promise should not exceed what PHP's termination phase can actually observe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both examples claimed to demonstrate a PHP fatal but triggered a catchable
Errorinstead (a method call onnull), which goes through the exception handler, not the shutdown handler the fatal-only mechanism actually targets.slim.php: split into/crash(a normal exception, answered by Slim's own error middleware) and/fatal(a genuine, portable, reproducible fatal —memory_limitlowered then exceeded — answered by this library instead).sse-interception.php: same fix, same genuine fatal trigger. Both verified in real execution (not justphp -l).composer.json: reframed the tagline as best-effort, last-resort rather than implying every fatal is caught — a SIGKILL, an OOM-killed process, or a segfault giveregister_shutdown_function()no chance to run at all.