Use ColumnDecimal->GetString#71
Closed
theory wants to merge 1 commit into
Closed
Conversation
theory
added
data types
Instead of converting the Int128 value from `clickhouse-cpp`, use the new `ColumnDecimal->GetString()` function to get the stringification of a decimal value fetched from ClickHouse. This greatly simplifies the code and restores the ability to use the `clickhouse-cpp` shared library, re-enabled in the `Makefile` for all OSes other than Darwin.
Collaborator
Author
|
with #254 this PR becomes moot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of converting the Int128 value from
clickhouse-cpp, use the newColumnDecimal->GetString()function to get the stringification of a decimal value fetched from ClickHouse. This greatly simplifies the code and restores the ability to use theclickhouse-cppshared library, re-enabled in theMakefilefor all OSes other than Darwin.Draft pull request pending ClickHouse/clickhouse-cpp#451. Resolves #90.