Skip to content

fix: send a User-Agent on every outbound request #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CodeWithJuber merged 1 commit into from
Aug 13, 2026
Merged

fix: send a User-Agent on every outbound request #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 23 additions & 10 deletions crates/hub-net/src/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,27 @@ use std::time::Duration;
use crate::NetError;
use crate::ssrf::SsrfPolicy;

/// The User-Agent every outbound request carries.
///
/// reqwest sends no User-Agent by default. GitHub rejects such requests
/// outright with `403 Request forbidden by administrative rules`, and several
/// WAF-fronted provider APIs do the same, so this is not cosmetic — without it
/// entire providers are unreachable no matter how good the credentials are.
const USER_AGENT: &str = concat!(
"connector-hub/",
env!("CARGO_PKG_VERSION"),
" (+https://github.com/CodeWithJuber/connector-hub)"
);

fn build_client(timeout_secs: u64) -> reqwest::Client {
reqwest::Client::builder()
.timeout(Duration::from_secs(timeout_secs))
.redirect(reqwest::redirect::Policy::none())
.user_agent(USER_AGENT)
.build()
.expect("failed to build HTTP client")
}

pub struct NetClient {
policy: SsrfPolicy,
timeout_secs: u64,
Expand All @@ -13,11 +34,7 @@ pub struct NetClient {

impl NetClient {
pub fn new(policy: SsrfPolicy) -> Self {
let client = reqwest::Client::builder()
.timeout(Duration::from_secs(30))
.redirect(reqwest::redirect::Policy::none())
.build()
.expect("failed to build HTTP client");
let client = build_client(30);

Self {
policy,
Expand All @@ -28,11 +45,7 @@ impl NetClient {

pub fn with_timeout(mut self, secs: u64) -> Self {
self.timeout_secs = secs;
self.client = reqwest::Client::builder()
.timeout(Duration::from_secs(secs))
.redirect(reqwest::redirect::Policy::none())
.build()
.expect("failed to build HTTP client");
self.client = build_client(secs);
self
}

Expand Down
Loading