London | 26-ITP-Sept | Fung Nin Lee | Sprint 1 | Forms Control - #1484
Open
leerogerfn wants to merge 9 commits into
Open
London | 26-ITP-Sept | Fung Nin Lee | Sprint 1 | Forms Control #1484leerogerfn wants to merge 9 commits into
leerogerfn wants to merge 9 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
leerogerfn
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
leerogerfn
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
leerogerfn
added
the
Needs Review
hey-hammad
added
Review in progress
hey-hammad
suggested changes
Sep 11, 2026
hey-hammad
left a comment
hey-hammad
left a comment
There was a problem hiding this comment.
Good work overall! The form is clear and covers the main requirements. A few small improvements to structure, validation, and accessibility would make it stronger.
| <h1>Product Pick</h1> | ||
| <fieldset> | ||
| <legend>Product Pick</legend> | ||
| </header> |
There was a problem hiding this comment.
Can you please review the header tag, there is no opening <header> tag.
| <input type="text" id="name" name="name" pattern=".*\S.*\S.*"> | ||
| <div> | ||
| <label for="email">Email</label> | ||
| <input type="email" id="email" name="email"> |
There was a problem hiding this comment.
The task says all fields are required. How will the form prevent submission if the user leaves the name, email, colour, or size blank?
| </main> | ||
| </fieldset> | ||
|
|
||
| <button type="submit">submit</button> |
There was a problem hiding this comment.
The submit button currently doesn't do anything, will moving to another place fix this?
| <label for="email">Email</label> | ||
| <input type="email" id="email" name="email"> | ||
| </div> | ||
| <p></p> |
There was a problem hiding this comment.
is there a reason for adding empty <p> tag here?
| <body> | ||
| <header> | ||
| <h1>Product Pick</h1> | ||
| <fieldset> |
There was a problem hiding this comment.
Please review the fieldset tags, think about the correct placement when building a form, more on this in the link below. Thanks
https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/fieldset
hey-hammad
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1004
Changelist