Skip to content

London| 26-ITP-Sep |Vaibhav Patel| Sprint 1 | Form control #1490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vibhu9407 wants to merge 1 commit into
base: main
Choose a base branch
from
+42 −2
Open

London| 26-ITP-Sep |Vaibhav Patel| Sprint 1 | Form control #1490

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 42 additions & 2 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,55 @@ <h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<div>
<label for="name">Customer Name:</label>
<input
type="text"
id="name"
name="name"
Comment on lines +18 to +21

@cjyuan cjyuan Sep 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chrome's "Developer tools" identified this possible improvement:

Image

required pattern=".*\S.*\S.*"
title="Please enter at least two non-space characters."
>
</div>
<div>
<label for="email">Email:</label>
<input
Comment on lines +26 to +28

@cjyuan cjyuan Sep 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is off.

Suggestion:

  • Look up the benefits of using a code formatter.
  • Install the Prettier extension for VS Code, then:
    • Use VS Code's Format Document feature to format your code.
    • Optionally, enable Format On Save and Format On Paste to keep your code consistently formatted.

Resource: Visual Studio Code - Formatting

Note: The formatter may not work correctly if your code contains syntax errors.

type="email"
id="email"
name="email"
required
>
</div>
<div>
<label for="color">T-shirt color:</label>
<select id="color" name="color" required>
<option value="">Please choose a color</option>
<option value="Black">Black</option>
<option value="White">White</option>
<option value="Blue">Blue</option>
</select>
</div>
<div>
<label for="size">T-shirt Size:</label>
Comment on lines +36 to +45

@cjyuan cjyuan Sep 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you spot a minor inconsistency between these two labels?

<select id="size" name="size" required>
<option value="">Please choose a Size</option>
<option value="XS">XS</option>
<option value="S">S</option>
<option value="M">M</option>
<option value="L">L</option>
<option value="XL">XL</option>
<option value="XXL">XXL</option>
</select>
</div>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
Comment on lines +56 to 59

@cjyuan cjyuan Sep 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the comments are no longer needed, you could delete them to keep the code clean.

</form>
</main>
<footer>
<!-- change to your name-->
<p>By HOMEWORK SOLUTION</p>
<p>By Vaibhav Patel</p>
</footer>
</body>
</html>
Loading