Manchester | 26-ITP-Sep | Salah Alsabhi | Sprint 2 | Coursework - #1551
Open
salahalsabhi wants to merge 16 commits into
Open
salahalsabhi wants to merge 16 commits into
salahalsabhi wants to merge 16 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
salahalsabhi
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
salahalsabhi
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
salahalsabhi
changed the title
salahalsabhi
added
the
Needs Review
hackertainment
added
Review in progress
hackertainment
added
Reviewed
|
Generally a high quality piece of work, just a few minor issues to fix. Keep it up. |
Author
|
Addressed the minor review points in the latest commit |
salahalsabhi
added
the
Needs Review
|
Thanks for your updated code. However, I cannot see the fixes for the following two issues. Would you please fix them as well? |
hackertainment
removed
the
Needs Review
| // Try breaking down the expression and using documentation to explain what it means | ||
| // It will help to think about the order in which expressions are evaluated | ||
| // Try logging the value of num and running the program several times to build an idea of what the program is doing | ||
| // num is a random whole number between 1 and 100 No newline at end of file |
There was a problem hiding this comment.
Your answer is correct. Just the requirement in line 8 means to explain the meaning of each break down of expression. So please add some more details on how the "random whole number between 1 and 100" conclusion comes from. Thank you.
Comment on lines
17
to
+18
| // a) How many function calls are there in this file? Write down all the lines where a function call is made | ||
| // Answer: 6 function calls. |
There was a problem hiding this comment.
Please write down all the lines where a function call is made. Thank you.
There was a problem hiding this comment.
Well done because you also describe the return value correctly as well.
Author
|
Thank you for feedback...I Fixed both remaining review comments in the latest commit. |
salahalsabhi
added
the
Needs Review
Author
|
Fixed both remaining review comments:
|
|
Congratulation, you have completed this PR successfully. |
hackertainment
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manchester| 26-ITP-Sep | Salah Alsabhi| Sprint2| Coursework
Learners, PR Template
Self checklist
Task code
CYF-1039
Changelist
Completed All Sprint2 exercises