Skip to content

Cape Town | sep-2026-ITP | Matthaus Bause | Sprint 3 | CYF-1053 - #1618

Open
chefmatthaus-hub wants to merge 28 commits into
CodeYourFuture:mainfrom
chefmatthaus-hub:acoursework/sprint-3
Open

Cape Town | sep-2026-ITP | Matthaus Bause | Sprint 3 | CYF-1053#1618
chefmatthaus-hub wants to merge 28 commits into
CodeYourFuture:mainfrom
chefmatthaus-hub:acoursework/sprint-3

Conversation

@chefmatthaus-hub

@chefmatthaus-hub chefmatthaus-hub commented Sep 28, 2026

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1053

Changelist

Working through the coursework for sprint 3

@chefmatthaus-hub
Created animal website and index.html
ced2c8b
@chefmatthaus-hub
Part 1 - Creating the repository
dfe221f
@chefmatthaus-hub
Added colour options for shirts
20df3e3
@chefmatthaus-hub
Changed Footer Name
5817f0b
@chefmatthaus-hub
Added shirt size options
857487a
@chefmatthaus-hub
Added Customer Details Field
66bd2de
@chefmatthaus-hub
changed shirt color label "for"
8bc3b93
@chefmatthaus-hub
Added a submit button
adf2ba2
@chefmatthaus-hub
added a <p> for the button
1979160
@chefmatthaus-hub
Neatened my line of code added a few <p> and <div>
b6c78a5
@chefmatthaus-hub
Added my first .css
cf2d074
@chefmatthaus-hub
Added .css to button
3c9fa22
@chefmatthaus-hub
Added .css to select
04a9d41
@chefmatthaus-hub
Removed shirt size label
daa9c1f
@chefmatthaus-hub
added additional hover .css to select
c1fc3d4
@chefmatthaus-hub
added .css to input
4e8e014
@chefmatthaus-hub
corrected email address field type to from "text" to "email"
0300b47
@chefmatthaus-hub
added select option to option field
1543377
@chefmatthaus-hub
added .css to field set
bb8c532
@chefmatthaus-hub
added "aria-label" to select field
f873d15
@chefmatthaus-hub
Delete animal-website/index.html
eb8a31f
@chefmatthaus-hub
Delete git-collaboration/animal-website/index.html
15d2158
@chefmatthaus-hub
added a style sheet file
f8c3552
@chefmatthaus-hub
made some required attributes
abf9de6
@netlify

netlify Bot commented Sep 28, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit f2aa74a
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6abac0a68413c20008e66e1b
😎 Deploy Preview https://deploy-preview-1618--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

Sign in to view
@chefmatthaus-hub chefmatthaus-hub changed the title CapeTown | sep-2026-ITP | Matthaus Bause | Sprint 3 | Sprint 3 Cape Town | sep-2026-ITP | Matthaus Bause | Sprint 3 | Sprint 3 Sep 28, 2026
@github-actions

This comment has been minimized.

Sign in to view
@chefmatthaus-hub chefmatthaus-hub added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 28, 2026
@chefmatthaus-hub chefmatthaus-hub added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 28, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 28, 2026
@chefmatthaus-hub chefmatthaus-hub added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 28, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 28, 2026
@chefmatthaus-hub chefmatthaus-hub added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 28, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 28, 2026
@chefmatthaus-hub chefmatthaus-hub added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 28, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 28, 2026
@chefmatthaus-hub chefmatthaus-hub added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 28, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 28, 2026
@chefmatthaus-hub chefmatthaus-hub added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 28, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 28, 2026
@chefmatthaus-hub chefmatthaus-hub added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 28, 2026
cjyuan
cjyuan reviewed Sep 29, 2026
View reviewed changes

@cjyuan cjyuan left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

Comment thread Sprint-3/5-stretch-extend/format-time.js
const hours = Number(time.slice(0, 2));
const hoursStr = time.slice(0, 2);
const hours = Number(hoursStr);
const minutes = time.slice(3, 5);

@cjyuan cjyuan Sep 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: The .slice() method supports negative indices, which count positions from the end of the string.

For example, str.slice(-3) returns the substring containing last three characters from str.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Sep 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chefmatthaus-hub @cjyuan