Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
281d67a
installed package.json and package.lock.json
Tobias-Amaechina Jul 8, 2026
c22490e
Wrote a test to pass the count.tes.js and update package.json
Tobias-Amaechina Jul 8, 2026
fd74c90
Wrote a test suite to check for no occurance
Tobias-Amaechina Jul 8, 2026
b2d0d65
Wrote a test case to pass the first set of conditions
Tobias-Amaechina Jul 12, 2026
5f543ef
Implement a condition in the function to handle everything thet ends …
Tobias-Amaechina Jul 12, 2026
c645b53
wrote test case to pass when number ends in 11, 12 and 13
Tobias-Amaechina Jul 12, 2026
5481fb4
wrote a test case for number ending in 12 and 13
Tobias-Amaechina Jul 12, 2026
340c19f
implement a condition to pass number ending in 2 as nd
Tobias-Amaechina Jul 12, 2026
7e5f8ee
implemented a condition to pass numers ending in 3 but not 13
Tobias-Amaechina Jul 12, 2026
eb5da76
implement a function to pass the dynmaict repeat of function
Tobias-Amaechina Jul 12, 2026
baaf08d
wrote a test case to check for dynamic count of str i time
Tobias-Amaechina Jul 12, 2026
f510445
console log with count 1 time and noticed the output equls 1 time
Tobias-Amaechina Jul 12, 2026
fd06505
wrote a test case for count equal to 0 to return empty string
Tobias-Amaechina Jul 12, 2026
8767246
printed the output of empty string when count is zero
Tobias-Amaechina Jul 12, 2026
8b6b488
wrote a test case to throw and error for negtive count
Tobias-Amaechina Jul 12, 2026
3eec672
wrote a functione condition to handle test case for negative count
Tobias-Amaechina Jul 12, 2026
4ab8301
fixed the error in get-ordinal-number.test.js
Tobias-Amaechina Jul 12, 2026
9c0d299
Gave a proper name fr the test to capture the exact number being tes…
Tobias-Amaechina Jul 20, 2026
db19ecb
update the code to valide the input first thereby failing fast
Tobias-Amaechina Jul 20, 2026
76883ee
update the code to valide the inpute and also commented out the call…
Tobias-Amaechina Jul 20, 2026
e1fc9b0
Wrote a test case to check for non-integer counts
Tobias-Amaechina Jul 20, 2026
7d02e38
wrote case for a case sensitivey scenerio
Tobias-Amaechina Jul 20, 2026
0c2366b
wrote a test check for non- alphabet character
Tobias-Amaechina Jul 20, 2026
2438af2
wrote a test case to check for empty string
Tobias-Amaechina Jul 20, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Sprint-3/2-practice-tdd/count.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
function countChar(stringOfCharacters, findCharacter) {
return 5
let count = 0;
for (let i = 0; i < stringOfCharacters.length; i++) {
if (stringOfCharacters[i] === findCharacter) {
count++;
}
}
return count;
}

module.exports = countChar;
25 changes: 25 additions & 0 deletions Sprint-3/2-practice-tdd/count.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,28 @@ test("should count multiple occurrences of a character", () => {
// And a character `char` that does not exist within `str`.
// When the function is called with these inputs,
// Then it should return 0, indicating that no occurrences of `char` were found.

test("should return 0 when character is not found", () => {
const str = "hello";
const char = "x";
const count = countChar(str, char);
expect(count).toEqual(0);
});
Comment on lines +26 to +31

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could consider testing a few more samples in this script - higher chance to detect bugs in code.

Also, the original specification did not clearly state whether the character match should be case-sensitive.
Most people would probably assume that it is, but to demonstrate our understanding or clarify the assumption we made,
we could add test cases to convey this. For examples,

  • A case to show that the match is case sensitive
  • A case to show that the function is expected to work also for non-alphabets

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback , I will add a few tests to show case sensitivity and non-alphabet behaviour


// Case : case-sensitivity expectations
// Test for when the alphabets are of different case
test("should be case-sensitive when matching characters", () => {
expect(countChar("AaA", "A")).toEqual(2); // uppercase A occurrences
expect(countChar("AaA", "a")).toEqual(1); // lowercase a occurrences
});

// New: non-alphabet characters
test("should count non-alphabet characters", () => {
expect(countChar("1231", "1")).toEqual(2);
expect(countChar("!?!?", "!")).toEqual(2);
});

// New: empty string
test("should return 0 for empty string input", () => {
expect(countChar("", "a")).toEqual(0);
});
14 changes: 13 additions & 1 deletion Sprint-3/2-practice-tdd/get-ordinal-number.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,17 @@
function getOrdinalNumber(num) {
return "1st";
const lastDigit = num % 10;
const lastTwoDigits = num % 100;


if (lastTwoDigits >= 11 && lastTwoDigits <= 13) {
return `${num}th`;
}

if (lastDigit === 1) return `${num}st`;
if (lastDigit === 2) return `${num}nd`;
if (lastDigit === 3) return `${num}rd`;
return `${num}th`;
}


module.exports = getOrdinalNumber;
69 changes: 69 additions & 0 deletions Sprint-3/2-practice-tdd/get-ordinal-number.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,72 @@ test("should append 'st' for numbers ending with 1, except those ending with 11"
expect(getOrdinalNumber(21)).toEqual("21st");
expect(getOrdinalNumber(131)).toEqual("131st");
});

// Case 2: Numbers ending with 11
// When the number ends with 11,
// Then the function should return a string by appending "th" to the number.
test("should append 'th' for numbers ending with 11", () => {
expect(getOrdinalNumber(11)).toEqual("11th");
expect(getOrdinalNumber(111)).toEqual("111th");
expect(getOrdinalNumber(211)).toEqual("211th");
expect(getOrdinalNumber(311)).toEqual("311th");
});

// Case 3 numbers ending in 12 and 13
test("should append 'th' for numbers ending with 12 and 13", () => {
expect(getOrdinalNumber(12)).toEqual("12th");
expect(getOrdinalNumber(13)).toEqual("13th");
expect(getOrdinalNumber(112)).toEqual("112th");
expect(getOrdinalNumber(113)).toEqual("113th");
});

// case 4: Numbers ending with 2 (but not 12)
// When the number ends with 2, except those ending with 12,
// Then the function should return a string by appending "nd" to the number.
test("should append 'nd' for numbers ending with 2, except those ending with 12", () => {
expect(getOrdinalNumber(2)).toEqual("2nd");
expect(getOrdinalNumber(22)).toEqual("22nd");
expect(getOrdinalNumber(32)).toEqual("32nd");
});

// Case 5: Numbers ending with 3 (but not 13)
// When the number ends with 3, except those ending with 13,
// Then the function should return a string by appending "rd" to the number.
test("should append 'rd' for numbers ending with 3, except those ending with 13", () => {
expect(getOrdinalNumber(3)).toEqual("3rd");
expect(getOrdinalNumber(23)).toEqual("23rd");
expect(getOrdinalNumber(33)).toEqual("33rd");
});

// Case 6: All other numbers
// When the number does not fall into the special 1/2/3 endings (or is one of the teen exceptions 11/12/13),
// Then the function should return a string by appending "th" to the number. Examples: 4, 14, 20, 100.
test("should append 'th' for numbers that neither end with 1/2/3 nor are 11/12/13 (e.g. 4, 14, 20, 100)", () => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just states numbers ending with 0, 4, ..., 9?

expect(getOrdinalNumber(4)).toEqual("4th");
expect(getOrdinalNumber(5)).toEqual("5th");
expect(getOrdinalNumber(6)).toEqual("6th");
expect(getOrdinalNumber(7)).toEqual("7th");
expect(getOrdinalNumber(8)).toEqual("8th");
expect(getOrdinalNumber(9)).toEqual("9th");
expect(getOrdinalNumber(10)).toEqual("10th");
expect(getOrdinalNumber(14)).toEqual("14th");
expect(getOrdinalNumber(15)).toEqual("15th");
expect(getOrdinalNumber(16)).toEqual("16th");
expect(getOrdinalNumber(17)).toEqual("17th");
expect(getOrdinalNumber(18)).toEqual("18th");
expect(getOrdinalNumber(19)).toEqual("19th");
expect(getOrdinalNumber(20)).toEqual("20th");
expect(getOrdinalNumber(24)).toEqual("24th");
expect(getOrdinalNumber(25)).toEqual("25th");
expect(getOrdinalNumber(26)).toEqual("26th");
expect(getOrdinalNumber(27)).toEqual("27th");
expect(getOrdinalNumber(28)).toEqual("28th");
expect(getOrdinalNumber(29)).toEqual("29th");
expect(getOrdinalNumber(30)).toEqual("30th");
});






Loading
Loading