Repository navigation
feat: record the ecModel format and GECKO release in saved ecModels - #12
Merged
Merged
Conversation
saveEcModel writes gecko_format and generator to the YAML metaData. loadEcModel upgrades a GECKO 3 ecModel in the loaded model with a warning and refuses a format it does not know. Part of #5.
Unit test results61 tests 61 ✅ 10s ⏱️ Results for commit 274ad36. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #5.
Main improvements in this PR:
saveEcModel: a YAML ecModel records its ecModel format (gecko_format: "4", numbered asproject_formatinmodel_adapter.toml) and the release that wrote it (generator: GECKO <version>) in itsmetaData. Before, no field recorded which GECKO wrote a file. Ageckopy_versionfrom earlier geckopy files is dropped. geckopy writes the same two keys.loadEcModel: protein usage and pool reactions in the GECKO 3 direction are turned forward in the loaded model byupgradeEcModel, with a warning that namesupgradeGECKOproject; before, such an ecModel was loaded unchanged. Agecko_formatabove 4 is an error that names the release that wrote the file.upgradeEcModelsetsgecko_formatto 4 when it is missing or lower.upgradeGECKOprojectrecords GECKO as thegeneratorof the ecModels it rewrites and reports an ecModel of a newer format as failed instead of rewriting it.Instructions on merging this PR:
developas target branch, and will be resolved with a squash-merge.mainas target branch, and will be resolved with a merge commit.