Skip to content

Address the RAVEN 3 Guide review - #89

Merged
edkerk merged 33 commits into
mainfrom
fix/guide-review
Oct 22, 2026
Merged

edkerk merged 33 commits into
mainfrom
fix/guide-review

Conversation

@edkerk

@edkerk edkerk commented Oct 17, 2026 •

Copy link
Copy Markdown
Collaborator

Addresses the RAVEN 3 Guide review (comments G01–G30).

The RAVEN and raven-toolbox submodules point at their develop heads, which include CompMetEng/RAVEN#7 and CompMetEng/raven-toolbox#175; the documented outputs come from that code.

Example checks

  • scripts/run_examples.py compares each example with the plain ```text block below it, and --update writes that form. The examples workflow also runs on RAVEN changes.
  • The MATLAB MILP examples run on GLPK, showing RAVEN's warning that recommends Gurobi; the Python job needs no Gurobi licence.

Guide

  • Every section the review flagged is rewritten to match what the code does: FBA, FVA, sampling, MOMA (quadratic, on a viable knockout), media, solvers, quality control, gap filling, tasks, curation, biomass, I/O, model structure, homology, KEGG, comparing models and engineering.
  • Gap filling: gapFillMILP and fill_gaps_milp only add reactions; the infeasible-model error of gapReport and gap_report is described.
  • Every example data file is listed, with how to run a page; the README and build notes describe the Sphinx build.

Reference

  • On the guide pages, function names link to their API entry: RAVEN and raven-toolbox names to the generated reference, cobrapy names to cobrapy's documentation through intersphinx. The "Functions on this page" tables link every entry, prose links the first mention per section, and cobrapy badges point at the named function.
  • The API reference renders numpydoc help as MyST.
  • The tutorials include their scripts from RAVEN's tutorials/ folder.
  • Pages describe RAVEN 3 and its develop branch; the RAVEN 2 → 3 pages compare RAVEN 2.11.3 with RAVEN 3.

Build

  • The MkDocs files are removed; the Sphinx build uses requirements.txt and scripts/gen_api_pages.py, and scripts/check_names.py runs on its own.

edkerk added 29 commits October 18, 2026 00:10
The MyST pages mark expected output with a bare text fence; the runner
only recognised the old title="Output" fence and so compared nothing.
Also trigger the examples workflow on RAVEN submodule changes.
RAVEN solves MILPs with its bundled GLPK and warns that Gurobi is faster,
so the gap-filling and minimal-medium examples no longer need Gurobi.
Fill in the curation outputs from the fixed curation functions.
The site is built with Sphinx. mkdocs.yml, its hooks, the mkdocs-gen-files
generator, the Material icons and stylesheet, and the one-time migration
scripts go; requirements-sphinx.txt and gen_api_pages_sphinx.py take the
plain names, and check_names.py is a standalone check.
@read-the-docs-community

read-the-docs-community Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Documentation build overview

📚 raven-docs | 🛠️ Build #35339823 | 📁 Comparing 0dde30a against latest (e3feefe)

  🔍 Preview build  

96 files changed · ± 96 modified

± Modified

scripts/autolink.py rewrites the inline code spans of the guide pages at build
time: RAVEN and raven-toolbox names link to their entries in the generated API
pages, cobrapy names to cobrapy's documentation through its intersphinx
inventory. Every name in a table row is linked, and the first mention per
section in the prose; the cobrapy badge in a table row points at the object
in that row.
@edkerk
edkerk merged commit 735c9ea into main Oct 22, 2026
3 checks passed
@edkerk
edkerk deleted the fix/guide-review branch October 22, 2026 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant