Skip to content

feat(documents): delete document folders; fix CI simulator destination; restructure GAP roadmap#4

Merged
Adron merged 2 commits into
mainfrom
dev
Jun 27, 2026
Merged

feat(documents): delete document folders; fix CI simulator destination; restructure GAP roadmap#4
Adron merged 2 commits into
mainfrom
dev

Conversation

@Adron

@Adron Adron commented Jun 27, 2026

Copy link
Copy Markdown
Member

Summary

Bundles the waiting work on dev: a new delete-document-folder capability in the Documents tab, a CI build fix (the GitHub runner no longer has the pinned simulator), and a roadmap-doc restructure around App Store ship-blockers.

What's included

  • documents — folder delete (feature): APIClient.deleteDocumentFolder(id:) issues DELETE /api/documents/folders/{id} (the server cascades to subfolders/documents); AppDataStore.removeDocumentFolder optimistically drops it from the cache. DocumentsView / DocumentFolderView expose Delete via swipe action and context menu, gated behind a confirmation dialog that warns about cascade. Failures re-sync (refreshDocuments() / load()) so a failed delete never leaves the UI out of sync; 401 routes through authState.handleUnauthorized() per the project's 401 contract. Adds APIClientDocumentsTests cases for the DELETE path and the 401 case.
  • ci — build fix: .github/workflows/ios.yml now builds against generic/platform=iOS Simulator instead of platform=iOS Simulator,name=iPhone 16,OS=latest. The runner image no longer ships a plain "iPhone 16" (only 16e/17/17 Pro/Air), so the build was failing to resolve a destination. A generic destination is correct for a build-only job and won't break on future runner image changes.
  • docs — roadmap restructure: GAP-NEXT-STEPS.md reorganized around App Store ship-blockers (Phase 14 UGC safety/moderation, Phase 0.5 Info.plist hygiene) with tiered remaining work; GAP-ENDPOINTS.md §H documents the unverified moderation endpoints; GAP-APPLE.md gains a pre-submission open-questions checklist and push-in-v1 scope. Also removes stray tool markup (</content></invoke>) accidentally written to the end of GAP-NEXT-STEPS.md.

Testing

  • xcodebuild build (generic iOS Simulator destination) — BUILD SUCCEEDED, which also confirms the CI fix locally.
  • xcodebuild test -only-testing:InterlinedListTests/APIClientDocumentsTests (iPhone 17 Pro, iOS 26.5, serialized) — 16 passed, 0 failures, including the two new folder-delete tests.

Notes

  • The folder-delete API contract (cascade behavior) matches GAP-ENDPOINTS.md's folder-scoped routing; behavior on a real backend wasn't exercised here (unit tests stub HTTP).
  • Heads-up: the git remote reports it has moved to CompositeCode/interlinedlist-ios — the push redirected successfully, but the origin URL may be worth updating.

🤖 Generated with Claude Code

Adron and others added 2 commits June 27, 2026 00:05
Adds folder deletion to the Documents tab, plus an unrelated CI fix and a
roadmap-doc restructure that were waiting in the tree.

- documents: APIClient.deleteDocumentFolder(id:) issues DELETE
  /api/documents/folders/{id} (server cascades to subfolders/docs);
  AppDataStore.removeDocumentFolder optimistically drops it from cache.
  DocumentsView/DocumentFolderView expose swipe + context-menu Delete with
  a confirmation dialog; failures re-sync so the UI never lies. 401 routes
  through authState.handleUnauthorized(). Adds APIClient tests for the
  DELETE path and the 401 case.
- ci: build against "generic/platform=iOS Simulator" instead of the pinned
  "iPhone 16,OS=latest", which no longer exists on the GitHub runner and
  was failing the build. Generic is correct for a build-only job and
  immune to future runner image changes.
- docs: restructure GAP-NEXT-STEPS around App Store ship-blockers (Phase 14
  UGC safety, Phase 0.5 hygiene) and tiered remaining work; document the
  unverified moderation endpoints in GAP-ENDPOINTS §H; expand GAP-APPLE
  with pre-submission open questions and push-in-v1 scope. Also strips
  stray tool markup accidentally written to the end of GAP-NEXT-STEPS.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@Adron Adron merged commit e2b2cad into main Jun 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant