Conversation
Adds folder deletion to the Documents tab, plus an unrelated CI fix and a
roadmap-doc restructure that were waiting in the tree.
- documents: APIClient.deleteDocumentFolder(id:) issues DELETE
/api/documents/folders/{id} (server cascades to subfolders/docs);
AppDataStore.removeDocumentFolder optimistically drops it from cache.
DocumentsView/DocumentFolderView expose swipe + context-menu Delete with
a confirmation dialog; failures re-sync so the UI never lies. 401 routes
through authState.handleUnauthorized(). Adds APIClient tests for the
DELETE path and the 401 case.
- ci: build against "generic/platform=iOS Simulator" instead of the pinned
"iPhone 16,OS=latest", which no longer exists on the GitHub runner and
was failing the build. Generic is correct for a build-only job and
immune to future runner image changes.
- docs: restructure GAP-NEXT-STEPS around App Store ship-blockers (Phase 14
UGC safety, Phase 0.5 hygiene) and tiered remaining work; document the
unverified moderation endpoints in GAP-ENDPOINTS §H; expand GAP-APPLE
with pre-submission open questions and push-in-v1 scope. Also strips
stray tool markup accidentally written to the end of GAP-NEXT-STEPS.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bundles the waiting work on
dev: a new delete-document-folder capability in the Documents tab, a CI build fix (the GitHub runner no longer has the pinned simulator), and a roadmap-doc restructure around App Store ship-blockers.What's included
APIClient.deleteDocumentFolder(id:)issuesDELETE /api/documents/folders/{id}(the server cascades to subfolders/documents);AppDataStore.removeDocumentFolderoptimistically drops it from the cache.DocumentsView/DocumentFolderViewexpose Delete via swipe action and context menu, gated behind a confirmation dialog that warns about cascade. Failures re-sync (refreshDocuments()/load()) so a failed delete never leaves the UI out of sync;401routes throughauthState.handleUnauthorized()per the project's 401 contract. AddsAPIClientDocumentsTestscases for the DELETE path and the 401 case..github/workflows/ios.ymlnow builds againstgeneric/platform=iOS Simulatorinstead ofplatform=iOS Simulator,name=iPhone 16,OS=latest. The runner image no longer ships a plain "iPhone 16" (only 16e/17/17 Pro/Air), so the build was failing to resolve a destination. A generic destination is correct for a build-only job and won't break on future runner image changes.GAP-NEXT-STEPS.mdreorganized around App Store ship-blockers (Phase 14 UGC safety/moderation, Phase 0.5 Info.plist hygiene) with tiered remaining work;GAP-ENDPOINTS.md§H documents the unverified moderation endpoints;GAP-APPLE.mdgains a pre-submission open-questions checklist and push-in-v1 scope. Also removes stray tool markup (</content></invoke>) accidentally written to the end ofGAP-NEXT-STEPS.md.Testing
xcodebuild build(generic iOS Simulator destination) — BUILD SUCCEEDED, which also confirms the CI fix locally.xcodebuild test -only-testing:InterlinedListTests/APIClientDocumentsTests(iPhone 17 Pro, iOS 26.5, serialized) — 16 passed, 0 failures, including the two new folder-delete tests.Notes
GAP-ENDPOINTS.md's folder-scoped routing; behavior on a real backend wasn't exercised here (unit tests stub HTTP).CompositeCode/interlinedlist-ios— the push redirected successfully, but the origin URL may be worth updating.🤖 Generated with Claude Code