Skip to content

fix(queue): preserve concurrent DiskSage and LineageWeave enrollments - #2201

Closed
seonghobae wants to merge 6 commits into
mainfrom
codex/queue-health-preserve-disksage-lineageweave
Closed

seonghobae wants to merge 6 commits into
mainfrom
codex/queue-health-preserve-disksage-lineageweave

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Verified supersession closure, not abandonment.

Child exact 9a30272ce33566d9a9c781f868443aac7edafed5 carried only two effective paths versus its historical merge base: config/actions_queue_health_repositories.json and tests/test_actions_queue_health_contract.py, preserving concurrent ContextualWisdomLab/LineageWeave and ContextualWisdomLab/disksage enrollment.

Canonical successor #2241 74613cffdc575fb87c2a9c7cb3efcb9036ebce09 explicitly consolidated LineageWeave, OriginWeave, disksage, noema, and quarantine-sandbox-runtime on refreshed #1150 and has now merged into protected .github/main as 991b85410270f2374ec1c30967ab6e7de9221fb8. Fresh file-by-file verification on that protected exact proves complete succession of this PR's valid delta/tests:

  • main config/actions_queue_health_repositories.json contains both LineageWeave and disksage and additionally preserves the successor enrollments (OriginWeave, noema, quarantine-sandbox-runtime);
  • main tests/test_actions_queue_health_contract.py requires the same combined allowlist, again with the stronger successor set.

Therefore #2201 has no remaining unique valid delta, fixture, contract, or evidence to restack. Historical CodeQL RED remains provenance for the now-repaired inherited central source but does not require keeping a duplicate child open. Closure is allowed specifically because protected #2241/main fully supersedes the two-path child without dropping either enrollment. No force update, destructive rebase, source copy, self-approval, or gate weakening was used.

Non-force two-parent reconciliation of #2196 with canonical queue-health owner #115042bb922. Preserve the exact two-path DiskSage enrollment delta and current protected-main ancestry; predecessor checks do not transfer.
Integrate concurrent bounded queue-health enrollments without overwriting either sibling. The allowlist and its exact-equality contract now retain both ContextualWisdomLab/disksage and ContextualWisdomLab/LineageWeave. This is a non-force two-parent descendant of #2196401a6ea and #2200c4054ee; collector behavior and workflow policy are unchanged.
@coderabbitai

coderabbitai Bot commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 74b864ea-acb0-4e74-9781-2589cb7cd8f3

📥 Commits

Reviewing files that changed from the base of the PR and between 42bb922 and 9a30272.

📒 Files selected for processing (2)
  • config/actions_queue_health_repositories.json
  • tests/test_actions_queue_health_contract.py

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Actions 큐 상태 점검 저장소 허용 목록에 ContextualWisdomLab/LineageWeave와 ContextualWisdomLab/disksage를 추가했습니다. 계약 테스트의 예상 저장소 목록도 같은 항목으로 갱신했습니다.

Changes

Actions 큐 상태 점검 허용 목록

Layer / File(s) Summary
허용 목록 및 계약 테스트 동기화
config/actions_queue_health_repositories.json, tests/test_actions_queue_health_contract.py
설정의 repositories 배열과 계약 테스트의 예상 payload에 두 저장소를 추가했습니다. 목록은 알파벳순으로 유지됩니다.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 9a302

The PR adds the two intended queue-health repositories and keeps the contract test aligned; no current merge-blocking risk is evident.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 …
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed PR 제목은 DiskSage와 LineageWeave의 동시 queue-health 등록을 유지하는 주요 변경 사항을 정확하고 구체적으로 설명합니다.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/queue-health-preserve-disksage-lineageweave

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Focused exact-source verification on 9a30272ce33566d9a9c781f868443aac7edafed5: reconstructed the checked-in workflow + allowlist + contract test and ran python -m pytest -q tests/test_actions_queue_health_contract.py → 2 passed. This does not replace hosted required checks.

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

@seonghobae I will review pull request #2201. The focused test result does not replace the hosted required checks.

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Copy Markdown
Contributor Author

Noema enrollment gap found against this integration exact 9a30272ce33566d9a9c781f868443aac7edafed5: the combined bounded allowlist still omitted ContextualWisdomLab/noema, while Noema #714 current exact a1228e72565d4280d01e1f877377ee0d3e107178 has four materialized jobs remaining pre-runner (runner_id=0, empty runner/group, steps=[]).

I preserved this PR as the integration parent and opened Draft child #2202 rather than another sibling against #1150. #2202 is a two-commit RED→repair stack: test-only 94c4eae9... first requires Noema while config omits it; causal f40638618... adds only the matching config entry. Effective child delta is exactly the existing allowlist config + exact-equality contract test. No collector logic, runner selector, rerun/cancellation behavior, or leaf Noema source changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant