Skip to content

fix(noema): retain sanitized sidecar evidence across outcomes - #2406

Merged
1 commit merged into
mainfrom
fix/noema-retain-sidecar-diagnostics-20260927
Sep 27, 2026
Merged

1 commit merged into
mainfrom
fix/noema-retain-sidecar-diagnostics-20260927

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Cause and scope

CO #1218 run 36025318452 attempt 3 started the sidecar but never logged health/preflight readiness before cancellation after six hours. The available artifact 10877250808 was produced by an earlier attempt; it cannot diagnose attempt 3. The Noema workflow gates its existing sanitized evidence uploader on failure(), excluding success and normal cancellation.

Repair

Use always() with the existing PR-number guard. Preserve the exact pinned uploader, two sanitized files, five-day retention and absent-file behavior. Hard runner timeout can still prevent cleanup/upload; this is not a claim to repair the unknown internal startup cause, provider capacity, or CodeQL authority.

Verification

  • RED: changed workflow contract fails on old source.
  • GREEN: all 12 Noema orchestrator workflow contract tests passed.
  • actionlint on the changed workflow passed.
  • git diff --check passed.
  • Exact attempt attribution and limits recorded in docs/noema-sidecar-evidence-1218.md.

Hosted current-head checks and qualifying independent review are required. No predecessor review or check is transferred.

@coderabbitai

coderabbitai Bot commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 51 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 1457d869-c490-45c9-adc7-ee22c2fabf08

📥 Commits

Reviewing files that changed from the base of the PR and between e6334e2 and 661f90c.

📒 Files selected for processing (3)
  • .github/workflows/noema-review.yml
  • docs/noema-sidecar-evidence-1218.md
  • tests/test_noema_orchestrator_workflow_contract.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae seonghobae closed this pull request by merging all changes into main in 472f80c Sep 27, 2026
@seonghobae
seonghobae deleted the fix/noema-retain-sidecar-diagnostics-20260927 branch September 27, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant