Skip to content

fix(ci): bind Noema continuation to the next retry attempt - #2488

Draft
seonghobae wants to merge 1 commit into
mainfrom
fix/noema-attempt-transition-2371
Draft

seonghobae wants to merge 1 commit into
mainfrom
fix/noema-attempt-transition-2371

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Summary

Bind each Noema 429 continuation to the immediately preceding retry attempt. A stale or malformed transition fails before dispatch, while attempts 0→1 and 1→2 remain valid.

This carries the remaining valid transition guard from #2371 onto the current central-dispatch workflow. The older PR's product-repository dispatch target is obsolete: the current workflow sends to the central .github handler and checks the exact live PR head and base.

Verification

  • RED: the executable workflow test dispatched attempt 1 when the current attempt was already 1.
  • GREEN: 69 focused Noema tests passed.
  • GITHUB_ACTIONS=true executable continuation test passed.
  • actionlint .github/workflows/noema-review.yml and git diff --check passed.

Hosted current-head review, required checks, and merge remain pending.

@coderabbitai

coderabbitai Bot commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 7 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 7c35e784-5f4e-48a4-adb2-b854a3c7836f

📥 Commits

Reviewing files that changed from the base of the PR and between 3295c25 and 5ec9f39.

📒 Files selected for processing (2)
  • .github/workflows/noema-review.yml
  • tests/test_noema_orchestrator_workflow_contract.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Exact-head admission correction — 5ec9f39a5372d38e77ea7992bcf58a0a2789c8cc

Ready is review admission only. Fresh audit against base 3295c259bcb688673170a1902f46d1d6c775bad4 found:

  • latest terminal workflow blockers: SAST Semgrep 36389435281=failure, Security Scan 36389435265=failure, Python Security 36389435243=failure, CodeQL PR 36389435293=failure

This PR is moved to Draft/Proposed until the causal owner repair is present on a successor exact head and re-audited. Queued/pending work is neither an additional blocker nor passing evidence. No Close, force push, destructive rebase, manual rerun, synthetic status/approval, merge, auto-merge, or bypass was performed.

@seonghobae
seonghobae marked this pull request as draft September 30, 2026 05:19

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant