Skip to content

fix(ci): install defusedxml lock in trusted uv quality gate #2496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
seonghobae wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −3
Draft

fix(ci): install defusedxml lock in trusted uv quality gate #2496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/trusted-uv-materializer-quality-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ on:
- "tests/test_uv*.py"
- "tests/test_repository_branch_coverage_*.py"
- "requirements-opencode-review-ci-hashes.txt"
- "requirements-noema-document-ci-hashes.txt"
- "pyproject.toml"
push:
branches: [main]
Expand All @@ -24,6 +25,7 @@ on:
- "tests/test_uv*.py"
- "tests/test_repository_branch_coverage_*.py"
- "requirements-opencode-review-ci-hashes.txt"
- "requirements-noema-document-ci-hashes.txt"
- "pyproject.toml"

concurrency:
Expand Down Expand Up @@ -104,10 +106,12 @@ jobs:
with:
python-version: "3.14"
cache: pip
cache-dependency-path: requirements-opencode-review-ci-hashes.txt
cache-dependency-path: |
requirements-opencode-review-ci-hashes.txt
requirements-noema-document-ci-hashes.txt

- name: Install hash-locked quality tooling
run: python -m pip install --disable-pip-version-check --require-hashes -r requirements-opencode-review-ci-hashes.txt
run: python -m pip install --disable-pip-version-check --require-hashes -r requirements-opencode-review-ci-hashes.txt -r requirements-noema-document-ci-hashes.txt

- name: Run trusted uv tests with complete branch coverage
run: |
Expand Down
7 changes: 6 additions & 1 deletion tests/test_trusted_uv_materializer_quality_workflow_contract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ def test_quality_workflow_runs_for_every_materializer_surface() -> None:
'"tests/test_uv*.py"',
'"tests/test_repository_branch_coverage_*.py"',
'"requirements-opencode-review-ci-hashes.txt"',
'"requirements-noema-document-ci-hashes.txt"',
'"pyproject.toml"',
)
for required_path in required_paths:
Expand Down Expand Up @@ -70,8 +71,12 @@ def test_full_quality_gate_proves_tests_coverage_docstrings_and_compilation() ->
assert 'python-version: "3.14"' in workflow
assert (
"python -m pip install --disable-pip-version-check --require-hashes "
"-r requirements-opencode-review-ci-hashes.txt"
"-r requirements-opencode-review-ci-hashes.txt "
"-r requirements-noema-document-ci-hashes.txt"
) in workflow
assert "defusedxml==0.7.1" in Path(
"requirements-noema-document-ci-hashes.txt"
).read_text(encoding="utf-8")
assert "branch = True" in workflow
assert "scripts/ci/materialize_base_python_requirements.py" in workflow
assert "fail_under = 100" in workflow
Expand Down
Loading