Skip to content

fix(security): annotate fixed-prefix maturin urlopen for Bandit B310 #2501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seonghobae wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −1
Open

fix(security): annotate fixed-prefix maturin urlopen for Bandit B310 #2501

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion scripts/ci/verify_release_maturin_tool_assets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@

def _download(filename: str) -> bytes:
url = f"https://github.com/PyO3/maturin/releases/download/v1.15.0/{filename}"
with urlopen(Request(url, headers={"User-Agent": "cwl-release-gate"}), timeout=60) as response:
# URL is a fixed https://github.com prefix; only the vetted asset filename varies.
with urlopen(Request(url, headers={"User-Agent": "cwl-release-gate"}), timeout=60) as response: # nosec B310
raw = response.read(MAX_ASSET_BYTES + 1)
if len(raw) > MAX_ASSET_BYTES:
raise ValueError("maturin release asset exceeds inspection limit")
Expand Down
Loading